ENH: Update XHKG calendar #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Liberation Day is another name for Allied Victory Day https://en.wikipedia.org/wiki/Victory_over_Japan_Day, which is currently implemented here in pmc: https://github.com/rsheftel/pandas_market_calendars/blob/master/pandas_market_calendars/exchange_calendar_hkex.py#L240. In general, I think we should port over the rest of the holidays from pmc. |
|
@jmccorriston - updated, I think I grabbed them all, will run another check when I have a sec. |
|
Confirmed no more diffs between the two calendars. |
|
Sorry for the delay, this lgtm then! |
jmccorriston
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR for updating XHKG. See details here: #152 (comment).
Pausing for now as:
pandas_market_calendarsLiberation Day(I can't see that in either calendar?)