ENH: NYSE Calendar prior to 1990 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change LGTM. I don't think we need to add tests pre-1990 but maybe we can add a disclaimer (or a runtime warning?) saying that holidays prior to 1990 have not been corroborated with volume data and are not included in the unit tests? |
jmccorriston
approved these changes
Sep 22, 2020
|
I have run this through the test suite in pandas_market_calendars that covers the pre-1990 and all tests pass. At some point I can add those tests here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
I didn't update the tests to go back to 1928. I wanted to make sure our tests still passed and I'm not sure testing that far back is worth it, but definitely what to hear what you all think.
If you're looking at the diff, it makes sense to look at the individual commits. I ran a formatter on the
.pyfiles because the code formatting was all over the place.