BUG: Fix GoodFriday for XCBF #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richafrank
reviewed
Sep 29, 2020
Co-authored-by: Richard Frank <richafrank@users.noreply.github.com>
jmccorriston
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Based on my best interpretation of https://www.cboe.com/trading-resources/cfe-expiration-holiday-calendars, this lgtm. Admittedly, that CBOE page is written extremely poorly so it's not 100% clear to me that we are interpreting it correctly.
philiptromans
referenced
this pull request
in philiptromans/exchange_calendars
Dec 6, 2021
This reverts commit 8269039.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
See also rsheftel/pandas_market_calendars#116