Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Add a devcontainer to allow codespaces development #174

Merged
merged 5 commits into from Oct 9, 2020

Conversation

gerrymanoim
Copy link
Collaborator

@gerrymanoim gerrymanoim commented Oct 8, 2020

Sets up an env that you can launch in your browser to work on trading calendars in your web browser. You can also use the same env in vscode remote containers if you need to. Should make it far easier for people to work on trading calendars.

We may want to revisit the etc/requirements.txt usage here.

image

Someday this can go in docs (but codespaces is still in private beta).

@@ -1,5 +1,4 @@
# This file is used to pin dependencies when running tests on travis/appveyor
-e .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update .github/workflows/main.yml to install trading calendars.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - though weird that tests passed anyway - I don't think this is strictly required for nosetests

@gerrymanoim gerrymanoim merged commit cb5e79f into master Oct 9, 2020
@gerrymanoim gerrymanoim deleted the codespaces branch October 9, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants