TST: Fix get_last_traded_dt on bcolz daily reader. #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove special handling for the last session of an asset, which was moving the last traded back a session. If the asset has data on a session, `get_last_traded_dt` should always return that session if it is the parameter to the method.
bartosh
pushed a commit
to bartosh/zipline
that referenced
this pull request
Sep 27, 2016
…r-session-get-last-traded-dt TST: Fix get_last_traded_dt on bcolz daily reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove special handling for the last session of an asset, which was
moving the last traded back a session.
If the asset has data on a session,
get_last_traded_dtshould alwaysreturn that session if it is the parameter to the method.