Fix microoptimizations #1568
Merged
Fix microoptimizations #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename _get_daily_window_for_sids to _get_daily_window_data. Rename _get_minute_window_for_assets to _get_minute_window_data. Rename _get_daily_data to get_daily_spot_value.
llllllllll
reviewed
Oct 28, 2016
| days_for_window, | ||
| end_dt, | ||
| field_to_use): | ||
| ends_at_midnight = (0 == end_dt.hour == end_dt.minute) |
There was a problem hiding this comment.
style nit: could we move 0 to the far rhs?
| @@ -748,6 +748,9 @@ def get_spot_value(self, asset, field, dt, data_frequency): | |||
| # otherwise just return a fixed value | |||
| return int(asset) | |||
|
|
|||
| # XXX: These aren't actually the methods that are used by the superclasses, | |||
| # so these don't do anything, and this class will likely produce unexpected | |||
| # results for history(). | |||
| def _get_daily_window_for_sid(self, asset, field, days_in_window, | |||
There was a problem hiding this comment.
why not just remove this method if it isn't used?
There was a problem hiding this comment.
I figured the original intent here would be more helpful for whoever eventually gets bitten by this. I just happened to notice that these aren't used because I was looking at renaming methods in data portal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.