-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix microoptimizations #1568
Fix microoptimizations #1568
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -748,6 +748,9 @@ def get_spot_value(self, asset, field, dt, data_frequency): | |
# otherwise just return a fixed value | ||
return int(asset) | ||
|
||
# XXX: These aren't actually the methods that are used by the superclasses, | ||
# so these don't do anything, and this class will likely produce unexpected | ||
# results for history(). | ||
def _get_daily_window_for_sid(self, asset, field, days_in_window, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not just remove this method if it isn't used? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I figured the original intent here would be more helpful for whoever eventually gets bitten by this. I just happened to notice that these aren't used because I was looking at renaming methods in data portal. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kk |
||
extra_slot=True): | ||
return np.arange(days_in_window, dtype=np.float64) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style nit: could we move
0
to the far rhs?