Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/BUG: Make emission_rate configurable in run_algorithm #2080

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lukevs
Copy link

@lukevs lukevs commented Jan 14, 2018

Currently, emission_rate in sim_params defaults to daily.

Defaulting to daily breaks minute-level benchmarks for set_benchmark (See #1827) because BenchmarkSource._initialize_precalculated_series chooses the frequency for looking up the benchmark data based on emission_rate. Daily -> daily reader -> KeyError.

Alternatives to exposing emission_rate to fix this benchmark issue seems to be either:

  • Set something in set_benchmark to specify the benchmark's rate (ex: set_benchmark(0, benchmark_frequency='minute'))
  • Default it to be the same as data_frequency - seems wrong

Let me know what I can add in terms of tests if this is a good approach.

@coveralls
Copy link

coveralls commented Jan 14, 2018

Coverage Status

Coverage remained the same at 87.57% when pulling 57aac53 on lukevs:master into a4a4401 on quantopian:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants