Use fixtures in test algo #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 1, 2018 12:04
Without I'm getting a ton of log garbage from matplotlib whenever a test fails.
ssanderson
commented
May 1, 2018
| SIM_PARAMS_DATA_FREQUENCY = 'daily' | ||
| DATA_PORTAL_USE_MINUTE_DATA = False | ||
|
|
||
| # FIXME: This currently uses benchmark returns from the trading |
There was a problem hiding this comment.
This is in service of a larger PR that aims to eventually kill TradingEnvironment entirely, so in the interest of changing as little as possible here, I'm not changing this behavior.
ehebert
approved these changes
May 1, 2018
| SIM_PARAMS_DATA_FREQUENCY = 'daily' | ||
| DATA_PORTAL_USE_MINUTE_DATA = False | ||
|
|
||
| # FIXME: This currently uses benchmark returns from the trading |
added 4 commits
May 1, 2018 17:48
Windows complains about using pip to update pip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.