Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixtures in test algo #2165

Merged
merged 9 commits into from May 1, 2018
Merged

Use fixtures in test algo #2165

merged 9 commits into from May 1, 2018

Conversation

@ssanderson
Copy link
Contributor

@ssanderson ssanderson commented May 1, 2018

No description provided.

Scott Sanderson added 3 commits May 1, 2018
Scott Sanderson
Without I'm getting a ton of log garbage from matplotlib whenever a test
fails.
SIM_PARAMS_DATA_FREQUENCY = 'daily'
DATA_PORTAL_USE_MINUTE_DATA = False

# FIXME: This currently uses benchmark returns from the trading

This comment has been minimized.

@ssanderson

ssanderson May 1, 2018
Author Contributor

This is in service of a larger PR that aims to eventually kill TradingEnvironment entirely, so in the interest of changing as little as possible here, I'm not changing this behavior.

This comment has been minimized.

@ehebert

ehebert May 1, 2018
Contributor

👍

Scott Sanderson added 2 commits May 1, 2018
@ehebert ehebert self-requested a review May 1, 2018
@ehebert
ehebert approved these changes May 1, 2018
Copy link
Contributor

@ehebert ehebert left a comment

LGTM. 👍 on being consistent with how test algorithms are created and invoked.

SIM_PARAMS_DATA_FREQUENCY = 'daily'
DATA_PORTAL_USE_MINUTE_DATA = False

# FIXME: This currently uses benchmark returns from the trading

This comment has been minimized.

@ehebert

ehebert May 1, 2018
Contributor

👍

Scott Sanderson added 4 commits May 1, 2018
Scott Sanderson
Windows complains about using pip to update pip.
Scott Sanderson
@ssanderson ssanderson merged commit 7a6b14b into master May 1, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssanderson ssanderson deleted the use-fixtures-in-test-algo branch May 1, 2018
@coveralls
Copy link

@coveralls coveralls commented May 1, 2018

Coverage Status

Coverage increased (+0.05%) to 87.163% when pulling f595446 on use-fixtures-in-test-algo into 5579b04 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.