Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence netket 3.3 warning #360

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

PhilipVinc
Copy link
Contributor

NetKet 3.3 now spits out a very innocuous warning when you set the number of samples to something that is not a multiple of the number of chains.

/home/filippovicentini/Dropbox/Ricerca/Codes/Python/netket/netket/vqs/mc/mc_state/state.py:58: UserWarning: n_samples=1000 (1000 per MPI rank) does not divide n_chains=16, increased to 1008 (1008 per MPI rank)

The logic is the same as before, we simply warn users that this is happening.
If you don't spceify the number of samples we'll pick the nearest multiple near 1000.
Since this looks like a book, I think it's nicer if users are not annoyed straight away.

I also took explicitly specify the dtype of Jastrow: if you use complex numbers you can describe signs and phases.
I don't speak russian, but in general we always try to stress that if you chose real parameters for your network you can only encode positive-valued states. It's a common source of questions in my experience.

Copy link
Collaborator

@Yorko Yorko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhilipVinc thanks for the contribution! Indeed, it's a Jupyter book accompanying a course on quantum ML, at this point, it's Russian-only. Indeed, the fewer warnings the better :)

@SemyonSinchenko SemyonSinchenko merged commit 880f3e6 into quantum-ods:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants