Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement #355, add pennylane implementaion of simon algorithm #370

Merged
merged 16 commits into from
Jan 22, 2022
Merged

implement #355, add pennylane implementaion of simon algorithm #370

merged 16 commits into from
Jan 22, 2022

Conversation

flatslm
Copy link
Contributor

@flatslm flatslm commented Jan 17, 2022

No description provided.

@vvssttkk
Copy link
Member

где-то через 10мин уже должно быть здесь

@vvssttkk vvssttkk linked an issue Jan 17, 2022 that may be closed by this pull request
дописать алгоритм Саймона с Qiskit на Pennylane #355
Closed
@SemyonSinchenko
Copy link
Collaborator

Я бы добавил {note} про то, почему схемы отличаются визуально, но по факту дают один результат.

vvssttkk
vvssttkk reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@vvssttkk vvssttkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и ещё pre-commits подправить

qmlcourseRU/book/qcalgo/simon_algorithm.md Outdated Show resolved Hide resolved
qmlcourseRU/book/qcalgo/simon_algorithm.md Outdated Show resolved Hide resolved
qmlcourseRU/book/qcalgo/simon_algorithm.md Outdated Show resolved Hide resolved
SemyonSinchenko
SemyonSinchenko approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У меня больше нет замечаний. @flatslm а в список авторов курса ты добавишся тогда?

SemyonSinchenko
SemyonSinchenko approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У меня больше нет замечаний. @flatslm а в список авторов курса ты добавишся тогда?

@flatslm
Copy link
Contributor Author

flatslm commented Jan 19, 2022

У меня больше нет замечаний. @flatslm а в список авторов курса ты добавишся тогда?

Я уже в авторах есть.

@flatslm
Copy link
Contributor Author

flatslm commented Jan 20, 2022

Вопрос - пре-коммит - как править?

@vvssttkk
Copy link
Member

Вопрос - пре-коммит - как править?

запустить локально pre-commit run -a и залить изменения. если не получится, смогу сам сделать, не беда

@flatslm
Copy link
Contributor Author

flatslm commented Jan 21, 2022

С пре-коммитом у меня задержка. с 3.6 питона переезжать надо.
планирую в ближайшие дни.

@vvssttkk
Copy link
Member

@flatslm спасибо за #355

@vvssttkk vvssttkk merged commit e03e98e into master Jan 22, 2022
@vvssttkk vvssttkk deleted the lecture/alg_simon_on_pennylane branch January 22, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvssttkk vvssttkk vvssttkk left review comments

@SemyonSinchenko SemyonSinchenko SemyonSinchenko approved these changes

Assignees

@flatslm flatslm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

дописать алгоритм Саймона с Qiskit на Pennylane
3 participants
@flatslm @vvssttkk @SemyonSinchenko