Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependency-review & codeql #435

Merged
merged 14 commits into from
Jul 26, 2022
Merged

Create dependency-review & codeql #435

merged 14 commits into from
Jul 26, 2022

Conversation

alexey-pronkin
Copy link
Collaborator

No description provided.

@alexey-pronkin alexey-pronkin linked an issue Jul 20, 2022 that may be closed by this pull request
@alexey-pronkin
Copy link
Collaborator Author

alexey-pronkin commented Jul 20, 2022

Add dependency review bot, it is needed because we will have different envs, just to check that all packages is secure before merge.

@vvssttkk
Copy link
Member

image

@alexey-pronkin
Copy link
Collaborator Author

@vtrokhymenko I think it's ok behavior, works as expected. You could add more security checks in this PR. We need to merge this PR before my PR with docker to check everything in that PR :)

@vvssttkk vvssttkk marked this pull request as ready for review July 21, 2022 19:31
@vvssttkk
Copy link
Member

codeql будет падать, тк явного кода в этой ветке нет; что в jb это другое для него

@vvssttkk
Copy link
Member

vvssttkk commented Jul 23, 2022

добавим когда появится хоть какой-то python код, который можно будет сразу лить в master

@vvssttkk
Copy link
Member

vvssttkk commented Jul 26, 2022

добавим когда появится хоть какой-то python код, который можно будет сразу лить в master

хотя, можно сделать так
image

и закрыть этот pr, а включить когда появится .py код в файле где-то в репо

@vvssttkk vvssttkk merged commit 9acdc6d into master Jul 26, 2022
@vvssttkk vvssttkk deleted the 431-add-code-scanning branch July 26, 2022 18:43
@vvssttkk vvssttkk changed the title Create dependency-review.yml Create dependency-review & codeql Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add code scanning
2 participants