Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializable device should validate args during op validation #2964

Closed
dabacon opened this issue May 4, 2020 · 3 comments
Closed

Serializable device should validate args during op validation #2964

dabacon opened this issue May 4, 2020 · 3 comments
Assignees
Labels
area/devices area/google/device area/google kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@dabacon
Copy link
Collaborator

dabacon commented May 4, 2020

Currently it doesn't check that the args match for gates. See TODO in serializable_device.py

@dabacon dabacon added this to Engine / Google in Bug Smash and Organize May 4, 2020
@dabacon
Copy link
Collaborator Author

dabacon commented May 4, 2020

Assigned this one to @dstrain115 because he left the TODO with his name in it, but feel free to unassign :)

@balopat balopat added area/devices kind/health For CI/testing/release process/refactoring/technical debt items labels Sep 16, 2020
@verult verult assigned verult and unassigned dstrain115 Mar 28, 2022
@verult
Copy link
Collaborator

verult commented Mar 28, 2022

Likely stale now that we are deprecating SerializableDevice, but will assign to myself to double check later whether this applies to the new device implementation.

@dstrain115
Copy link
Collaborator

This class no longer exists, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devices area/google/device area/google kind/health For CI/testing/release process/refactoring/technical debt items
Projects
No open projects
Bug Smash and Organize
Engine / Google
Development

No branches or pull requests

5 participants