Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added demo tests #15

Merged
merged 16 commits into from
Oct 5, 2017
Merged

added demo tests #15

merged 16 commits into from
Oct 5, 2017

Conversation

babbush
Copy link
Contributor

@babbush babbush commented Oct 4, 2017

Addressing issue #7

@babbush babbush requested a review from jarrodmcc October 4, 2017 00:49
jarrodmcc
jarrodmcc previously approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@jarrodmcc jarrodmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much needed tests for the demo.

jarrodmcc
jarrodmcc approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@jarrodmcc jarrodmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now that tests are passing for at least some representatives of each python version.

@jarrodmcc jarrodmcc merged commit 2d87a72 into quantumlib:master Oct 5, 2017
@babbush babbush mentioned this pull request Oct 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmcc jarrodmcc jarrodmcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@babbush @jarrodmcc