added general Fermi-Hubbard model and HubbardLattice helper class #465
Conversation
|
Ready for review. Can split up into smaller PRs if needed. |
| periodic=periodic) | ||
| print(x_dimension, y_dimension) | ||
| print(len(hubbard_model_special.terms)) | ||
| print(len(hubbard_model_general.terms)) |
There was a problem hiding this comment.
Leftover debug statements.
|
The failing tests seem to have nothing to do with this PR. Are those a known issue? |
|
Not sure. Looks like some issue with the pubchem website might have occurred. I'll restart tests. |
| The lattice can have periodic boundary conditions or not. | ||
| For a lattice with `n` sites, there are `N = k * n` spatial orbitals. | ||
| In the standard Fermi-Hubbard model (which we call the "spinful" model), | ||
| there is room for an "up" fermion and a "down" fermion at each site on the |
There was a problem hiding this comment.
Perhaps more accurate to say "at each spatial orbital" rather than each "site", since you say there are n sites sand N =k*n spatial orbitals.
|
|
||
| where | ||
|
|
||
| - The indices :math:`(i, j)` and :math:`{i, j}` run over ordered and |
There was a problem hiding this comment.
I think you need \{i, j\} for the brackets to show up when rendered.
|
Do you have a reference where I could read about the multi-band Hubbard model? Is there one that you were looking at while implementing this? |
|
Yes to |
|
My understanding of the multi-band Hubbard model is mostly from conversations. I haven't seen any papers that describe it in the abstract. |
|
@kevinsung Here's one example: https://arxiv.org/pdf/1007.5431.pdf |
| optional, and will default to SpinPairs.ALL. In any case, it is | ||
| ignored for spinless lattices. | ||
|
|
||
| Each potential parameter is a tuple (dof, coefficient). |
There was a problem hiding this comment.
While you're at it, please explain where edge_type comes from. This docstring needs to be expanded to make it easier for the user to know how to form the arguments.
|
Is that clearer? |
|
Overriding status check being stuck, since all checks passed. |
…antumlib#465) * added general Fermi-Hubbard model and HubbardLattice helper class * made more 2.7 compliant * more 2.7 compliance * fixed bug and more 2.7 compliance * increased coverage * increased coverage * removed debugging vestiges * coverage * removed unneeeded pass statements for coverage * fixed FermiHubbardModel docstring * expanded docstring for FermiHubbardModel.__init__
No description provided.