Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTket dependency is resolving badly #104

Closed
mpharrigan opened this issue Dec 1, 2020 · 5 comments · Fixed by #119
Closed

PyTket dependency is resolving badly #104

mpharrigan opened this issue Dec 1, 2020 · 5 comments · Fixed by #119

Comments

@mpharrigan
Copy link
Collaborator

The build is failing.

https://github.com/quantumlib/ReCirq/runs/1475828878?check_suite_focus=true#step:6:47

Need to check if they released a new version and why it's not backwards compatible. Pin or fix as necessary

@mpharrigan
Copy link
Collaborator Author

I can't reproduce this issue locally with the latest versions of pytket and pytket-cirq

@mpharrigan
Copy link
Collaborator Author

mpharrigan commented Dec 1, 2020

There might be something funky with the (new?) pip dependency resolver where it is installing pytket 0.6.1 (latest) but pytket-cirq 0.3 (old)

https://pypi.org/project/pytket-cirq/#history

@mpharrigan
Copy link
Collaborator Author

mpharrigan commented Dec 1, 2020

pytket-cirq 0.5 has the following install_requires

    install_requires=["pytket ~= 0.6", "cirq ~= 0.8.0"],

pytket-cirq 0.3 has this:

    install_requires=["pytket ~=0.5", "cirq ~=0.6"],

pytket-cirq 0.3.1 has this:

    install_requires=["pytket ~=0.5", "cirq == 0.8"],

So 0.3 is getting picked up because it has the loosest pin; but it breaks on import because the pytket dependency is too loose.

@mpharrigan mpharrigan changed the title PyTket issue PyTket dependency is resolving badly Dec 1, 2020
@mpharrigan
Copy link
Collaborator Author

If I pin all three packages, it warns that pip will break when they flip on the "new resolver".

@mpharrigan
Copy link
Collaborator Author

The pypa people -- with a straight face -- propose forking dependencies to work around these types of issues! https://pip.pypa.io/en/latest/user_guide/#loosen-the-requirements-of-your-dependencies

mpharrigan added a commit to mpharrigan/ReCirq that referenced this issue Dec 1, 2020
bandaid for quantumlib#104, which I will keep open until a more permanent fix is found.
mpharrigan added a commit that referenced this issue Dec 1, 2020
* Workaround pyket dependency resolution issue

bandaid for #104, which I will keep open until a more permanent fix is found.

* doesn't like comment at the start of run block

* oh wait it didn't like my non-escaped bash

* it says it isn't using wheels without `wheel`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant