-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyTket dependency is resolving badly #104
Comments
I can't reproduce this issue locally with the latest versions of pytket and pytket-cirq |
There might be something funky with the (new?) pip dependency resolver where it is installing pytket 0.6.1 (latest) but pytket-cirq 0.3 (old) |
pytket-cirq 0.5 has the following install_requires=["pytket ~= 0.6", "cirq ~= 0.8.0"], pytket-cirq 0.3 has this: install_requires=["pytket ~=0.5", "cirq ~=0.6"], pytket-cirq 0.3.1 has this: install_requires=["pytket ~=0.5", "cirq == 0.8"], So 0.3 is getting picked up because it has the loosest pin; but it breaks on import because the pytket dependency is too loose. |
If I pin all three packages, it warns that pip will break when they flip on the "new resolver". |
The pypa people -- with a straight face -- propose forking dependencies to work around these types of issues! https://pip.pypa.io/en/latest/user_guide/#loosen-the-requirements-of-your-dependencies |
bandaid for quantumlib#104, which I will keep open until a more permanent fix is found.
* Workaround pyket dependency resolution issue bandaid for #104, which I will keep open until a more permanent fix is found. * doesn't like comment at the start of run block * oh wait it didn't like my non-escaped bash * it says it isn't using wheels without `wheel`
The build is failing.
https://github.com/quantumlib/ReCirq/runs/1475828878?check_suite_focus=true#step:6:47
Need to check if they released a new version and why it's not backwards compatible. Pin or fix as necessary
The text was updated successfully, but these errors were encountered: