Add helper function for downloading Fermi-Hubbard publication data #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
reviewed
Dec 17, 2020
| @@ -209,3 +213,50 @@ def rainbow23_layouts(sites_count: int = 8) -> Tuple[ZigZagLayout]: | |||
| for flip in (False, True) | |||
| for exchange in (False, True) | |||
| for reverse in (False, True)) | |||
|
|
|||
|
|
|||
| def fetch_publication_data( | |||
There was a problem hiding this comment.
The other function is in recirq.documentation_utils. I don't know if that's the exact correct place to put it, but I think there's some value to having all the example-dataset functionality outside of the projects so you can find all of them more easily in one place. What do you think?
There was a problem hiding this comment.
I guess there are two options which make sense:
- Put download functions in the same place (
documentation_utils.get_qaoa_dataanddocumentation_utils.get_fermi_hubbard_data). - Put download functions in respective modules (
qaoa.get_publication_dataandrecirq.get_publication_data).
I'm not too partial to either so I'm good to go with your intuition here. Maybe (2) is slightly more natural to me since I would probably look there before documentation_utils if I were guessing. This could be improved by renaming documentation_utils or putting both functions in a new module though.
mpharrigan
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108.