Better error message for nbfmt #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
reviewed
Jan 27, 2021
| @@ -11,7 +11,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": null, | |||
There was a problem hiding this comment.
why is this change included?
There was a problem hiding this comment.
Ah, leftover from intentional unformatting. Fixed now.
mpharrigan
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #124. The
nbfmterror message is the "Cirq error message" which says to runcheck/nbformatwhich doesn't exist in ReCirq. This PR updates the error message to reference the correct file, namelydev_tools/nbfmt. For example:The following notebooks require formatting. - docs/fermi_hubbard/experiment_example.ipynb Notebooks are not formatted. Please run 'dev_tools/nbfmt --apply'