Deal with scipy unceremoniously removing wrap_function
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2021
Closed
|
Thanks for fixing this! |
Change-Id: I9072119de859a36bfa19ccf0e3e75674090d7244
mpharrigan
force-pushed
the
2021-07-scipy-fix
branch
from
7715d7d
to
f3de61b
Compare
balopat
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
LGTM
For the record, it is a verbatim copy from https://github.com/scipy/scipy/blob/maintenance/1.6.x/scipy/optimize/optimize.py#L454.
Consider adding the https://github.com/scipy/scipy/blob/maintenance/1.6.x/LICENSE.txt to the top of this file referring to wrap_function.
|
added |
dstrain115
approved these changes
Jul 15, 2021
recirq/optimize/__init__.py
Outdated
| # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
|
|
||
| def wrap_function(function, args): |
There was a problem hiding this comment.
I generally don't think it's a great idea to put code in init files. Is there a reason we can't put this in its own file and import it into the package?
recirq/optimize/__init__.py
Outdated
| def wrap_function(function, args): | ||
| # This function existed in scipy prior to 1.7 | ||
| # It must not have been considered part of the public API, as it has | ||
| # disappeared without a trace. |
There was a problem hiding this comment.
Should this be a docstring instead of line comments?
Change-Id: I6b0c01943089170177ed133eafc310de4328ef70
balopat
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.