Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hfvqe tutorials #80

Merged
merged 4 commits into from Oct 28, 2020
Merged

Hfvqe tutorials #80

merged 4 commits into from Oct 28, 2020

Conversation

ncrubin
Copy link
Contributor

@ncrubin ncrubin commented Oct 16, 2020

No description provided.

@ncrubin
HFVQE tutorial in docs
f5b6cfd 
Also a new tutorial  on making molecular data for the experiment.
@ncrubin
Merge branch 'master' of github.com:quantumlib/ReCirq into hfvqe-tuto…
caa24f8 
…rials
@mpharrigan mpharrigan self-requested a review October 21, 2020 19:43
mpharrigan
mpharrigan requested changes Oct 21, 2020
View reviewed changes
docs/hfvqe/Making MolecularData.ipynb Outdated
"cell_type": "markdown",
"metadata": {},
"source": [
"# Making Molecule Files for HFVQE\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you name this file in lower_snake_case with no spaces

docs/hfvqe/Making MolecularData.ipynb Outdated
},
{
"data": {
"image/png": "iVBORw0KGgoAAAANSUhEUgAAATYAAAD4CAYAAABmKcrZAAAAOXRFWHRTb2Z0d2FyZQBNYXRwbG90bGliIHZlcnNpb24zLjMuMiwgaHR0cHM6Ly9tYXRwbG90bGliLm9yZy8vihELAAAACXBIWXMAAAsTAAALEwEAmpwYAAATWElEQVR4nO3de4xedZ3H8fenUwtSLrZWC7ZFiKKGJa7oBFHiZaXu1kuoyboKLm4xmGbjoniLi0uiicYEd71gskS3QbQKAXcrGxvpgogSdxNlGS5BLiIVd2mhUEp3UUAonfnsH89TdmaeGebMnDPPOc+Zzys5mXOeOfmdb2fgO7/7kW0iItpkUd0BRERULYktIloniS0iWieJLSJaJ4ktIlpncT8fNnToUi9evryfj4ySFu2rppyxJdWUE89u/969jD72uMqU8Wd/stSP7B0tdO9Ntz11je11ZZ43H/qa2BYvX86LPvHRfj5y4Hiomuk3Gi313/YzDr2vmkr9Y0ePVVJOI1Xzo4YKfvUPfPnC0mU8sneU/7zm6EL3Dh11z4rSD5wHfU1sEdF8BsYY7D9ESWwRMYExT7tYU7SpktgiokdqbBHRKsaMDvhSy1I9w5LWSbpb0nZJ51UVVETUawwXOppqzjU2SUPARcBbgZ3AjZK22r6zquAiov8MjDY4aRVRpsZ2ErDd9r229wFXAOurCSsi6rRga2zAKmDHuOudwGsn3yRpI7ARYGjZshKPi4h+MPD0gPexzfvgge1NwCaAg45eM9g/rYgFwHjgm6JlEtv9wJpx16u7n0XEIDOMDnZeK9XHdiNwnKRjJS0BTge2VhNWRNSls/Kg2NFUc66x2d4v6RzgGmAIuMT2HZVFFhE1EaOVLYCtR6l5bLa32X6Z7ZfY/kJVQUVEfTqDByp0FFF0vqukP5dkScNl/w1ZeRARE3TmsVVTYys631XSYcC5wA1VPDcbTUZEjzGr0FFA0fmunwe+CDxZRfxJbBExwYEaW5EDWCFpZNyxcVJxU813XTX+BkmvBtbYvqqqf0OaohX4zXu/UVlZL/neX1dSzjvecFMl5Vz176+ppJznPljN39A/HFnNWNzYIdVty7PoiaFKyhlbWkFMi8rP0zBitHidZ4/tOfeJSVoEfAU4a65lTCWJLSJ6FGxmFjHTfNfDgBOA6yUBHAlslXSa7ZG5PjSJLSImMGKfq6mFMm6+K52EdjrwvmeeZT8KPLO9uKTrgU+WSWqQxBYRk3Qm6FbTdTDdfFdJnwNGbM/LpP4ktojoUeUEXdvbgG2TPvvMNPe+uYpnJrFFxAS2GPVgT5hIYouIHmMDvqQqiS0iJugMHgx2ahjs6COiclUOHtQliS0ieoxWN4+tFklsETHBLFceNFISW0T0GMuoaES0SWcRfBJbRLSIEU9Xt6SqFklsETGBTSboRkTbKBN0I6JdTGpsEdFCGTyIyna9BXjZ+bdVUs5VX6hm51tVtNFsVTvfevm+SspZtHdJJeUA6IVPVVLOot0HlS9krHwT0hR+n0FjJbFFxASd1+8NdmoY7OgjYh4M/guTk9giYgKTlQcR0UKpsUVEq9hauDU2SWuA7wAr6dReN9n+WlWBRUQ9OoMHC3dJ1X7gE7ZvlnQYcJOka23fWVFsEVGLBfzOA9u7gF3d899LuovOq+uT2CIGWGfwIH1sSDoGOBG4oYryIqJeC37lgaRDge8DH7X9uym+vxHYCDC0bFnZx0XEPFvwKw8kPYdOUrvM9pVT3WN7E7AJ4KCj17jM8yKiPxbsy1wkCfgmcJftr1QXUkTUyYanxwY7sZWJ/hTg/cBbJN3aPd5eUVwRUZNOU3RRoaOpyoyK/gcM+PTkiJhSVh5ERKtkukdEtNACXlIVEe2Vdx7U4KUf+0Ul5Wz/6smVlFOlX3/hlXWHMEHTlgyqwp1vq+Iqdr5tkM6oaMN+8bM0kIktIubPgp+gGxHtlKZoRLRKRkUjopUyKhoRrWKL/QOe2AY7+oiYF2NWoaMISesk3S1pu6Tzpvj+xyXdKek2SddJenHZ+JPYImKCA31sVSQ2SUPARcDbgOOBMyQdP+m2W4Bh268EtgB/X/bfkMQWET0qrLGdBGy3fa/tfcAVwPrxN9j+qe0nupe/AFaXjT99bBExwSznsa2QNDLuelN3D8YDVgE7xl3vBF77LOWdDfxb0YdPJ4ktInrMYh7bHtvDVTxT0pnAMPCmsmUlsUXEBDbsr26jyfuBNeOuV3c/m0DSWuB84E22nyr70CS2iOhR4QTdG4HjJB1LJ6GdDrxv/A2STgT+CVhne3cVD01ii4gJqlwranu/pHOAa4Ah4BLbd0j6HDBieyvwD8ChwL903jjAfbZPK/PcJLaI6OEKl1TZ3gZsm/TZZ8adr63sYV1JbBHRI4vgI6JV7CyCj4jWEaMD/vq9JLaI6FFlH1sd+pvYDNpf/gdW1ZbeI++u5j3Pw1s+Xkk5EU2Q/dgion3c6WcbZElsEdEjo6IR0SrO4EFEtFGaohHROoM+Klq6vilpSNItkn5YRUARUS+7k9iKHE1VRY3tXOAu4PAKyoqIBhj06R6lamySVgPvAC6uJpyIaAK72NFUZWtsFwKfAg6b7gZJG4GNAEPLlpV8XETMNyPGBnxUdM7RS3onsNv2Tc92n+1NtodtDw8tXTrXx0VEH7ng0VRlamynAKdJejtwMHC4pEttn1lNaBFRCy/gUVHbn7a92vYxdLb7/UmSWkRLDHiVLfPYIqLHoNfYKklstq8Hrq+irIiol4GxsSS2iGgTA6mxRUTbNHmOWhFJbBHRK4ltFgReXP4ntuZHoxUEA8Nk59uIXs1eB1pEamwR0Ss1tohoFYMzKhoR7ZPEFhFtk6ZoRLROEltEtEom6EZEG2WCbkS0T0ZFI6JtlBpbRLRKw/daKyKJLSImUQYPIqKFUmOLiNYZqzuAcpLYImKiFsxjG+yXB0bEvJCLHYXKktZJulvSdknnTfH9gyR9r/v9GyQdUzb+JLaI6FXRW6okDQEXAW8DjgfOkHT8pNvOBv7H9kuBrwJfLBt+EltEzKeTgO2277W9D7gCWD/pnvXA5u75FuBUSaXawn3tY9OSUQ5a81jpcnb86aEVRAOuKK1rwDtaIyabxQTdFZJGxl1vsr1p3PUqYMe4653AayeV8cw9tvdLehR4PrBnNjGPl8GDiJjIzGZJ1R7bw/MYzZykKRoRvap7E/z9wJpx16u7n015j6TFwBHAI3OOnSS2iJhChaOiNwLHSTpW0hLgdGDrpHu2Ahu65+8GfmKX218kTdGI6FXRyoNun9k5wDXAEHCJ7TskfQ4Ysb0V+CbwXUnbgb10kl8pSWwR0avCJVW2twHbJn32mXHnTwJ/Ud0TSzZFJT1P0hZJv5J0l6TXVRVYRNSjaDO0yVsbla2xfQ242va7u+3nQyqIKSLqtlA3mpR0BPBG4CyA7uS7fdWEFRF1anJtrIgyTdFjgYeBb0m6RdLFkpZOvknSRkkjkkZGH32ixOMiom+qm+5RizKJbTHwauDrtk8EHgd6Frja3mR72Pbw0BFpqUY0Xgv62Moktp3ATts3dK+30El0ETHoFmqNzfaDwA5JL+9+dCpwZyVRRUStNFbsaKqyo6IfBi7rjojeC3ygfEgREeWUSmy2bwUatwA2IkpqcDOziKw8iIiJGj4wUEQSW0T0SmKLiNZJYivO+4Z4akf53W8XrXyygmhg7KGDKyknok1Es0c8i0iNLSImSh9bRLRSEltEtE4SW0S0TZqiEdE+SWwR0SrOqGhEtFFqbBHRNulji4j2SWKLiFZp+CaSRSSxRcQEIk3RiGihJLaIaJ8ktohonSS2iGiV7O4REa2UxBYRbZMlVbNR0fyYqna+PeiRMu+L/n9PPX/A/yuImCRN0Yhol0zQjYhWSmKLiDbJyoOIaCWNDXZmS2KLiIla0MdWalhQ0sck3SHpdkmXS8qLOiNaQC52NNWcE5ukVcBHgGHbJwBDwOlVBRYRNXLBowRJyyVdK+me7tdlU9zzKkk/71agbpP03iJll53ItRh4rqTFwCHAAyXLi4gG6FON7TzgOtvHAdd1ryd7Avgr238ErAMulPS8mQqec2KzfT/wJeA+YBfwqO0fTb5P0kZJI5JGRh9/fK6Pi4h+6kONDVgPbO6ebwbe1ROG/Wvb93TPHwB2Ay+YqeAyTdFl3cCOBV4ELJV05hSBbbI9bHt4aOnSuT4uIvql+5aqIgew4kDFpXtsnMWTVtre1T1/EFj5bDdLOglYAvxmpoLLjIquBX5r++HuQ68EXg9cWqLMiKjZLOex7bE9PG1Z0o+BI6f41vnjL2xbmv6pko4CvgtssD3jGsYyie0+4GRJhwB/AE4FRkqUFxFN4WqGPG2vne57kh6SdJTtXd3EtXua+w4HrgLOt/2LIs8t08d2A7AFuBn4ZbesTXMtLyKao0+DB1uBDd3zDcAPeuKQlgD/CnzH9paiBZcaFbX9WduvsH2C7ffbfqpMeRHRAEUHDsontguAt0q6h07X1gUAkoYlXdy95z3AG4GzJN3aPV41U8FZeRARPfqxH5vtR+h0YU3+fAT4YPf8UubQb5/EFhE9stFkRLSLqWzwoC79TWzqHiUtfryCQsjOtxHTafI60CJSY4uIXklsEdEm2WgyItrHzkaTEdFCg53XktgioleaohHRLgbSFI2I1hnsvJbEFhG90hSNiNbJqGhEtEsLXr+XxBYRE3Qm6A52Zktii4heA76MOoktInqkxhYR7ZI+tohon6wVjYg2SlM0IlrF2Ro8ItooNbZZqOgvwf6l1fzQD95d6u2Dz3jyhQP+5y1issHOa6mxRUQvjQ32H+sktoiYyGSCbkS0i3Am6EZECw14Ypux91zSJZJ2S7p93GfLJV0r6Z7u12XzG2ZE9JVd7GioIsOC3wbWTfrsPOA628cB13WvI6INDvSxFTkaasbEZvtnwN5JH68HNnfPNwPvqjasiKiTxsYKHU011z62lbZ3dc8fBFZWFE9E1K7ZzcwiSg8e2LY0/Q7pkjYCGwGGlqUrLqLxzMAntrlOvX9I0lEA3a+7p7vR9ibbw7aHh5YunePjIqKv2t7HNo2twIbu+QbgB9WEExFNILvQ0VRFpntcDvwceLmknZLOBi4A3irpHmBt9zoi2mLAp3vM2Mdm+4xpvnVqxbFERBPYMNrgdmYBWXkQEb0aXBsrIoktInoNeGKrZkOyiGgPA2MudpQwm6WZkg7v9vH/Y5Gyk9giYhKDx4od5cxmaebngZ8VLbi/TVGBK0ilix9T+ULIzrcRUzL9GjxYD7y5e74ZuB7428k3SXoNndVNVwPDRQpOjS0iehWf7rFC0si4Y+MsnjLj0kxJi4AvA5+cTfgZPIiIXsUHD/bYnrYWJenHwJFTfOv8iY+bdmnmh4BttndKxVtqSWwRMUl1k29tr53ue5IeknSU7V3PsjTzdcAbJH0IOBRYIukx28+6VVoSW0RMZKA/WxIdWJp5AdMszbT9lwfOJZ0FDM+U1CB9bBExlf4sqZpyaaakYUkXlyk4NbaImKQ/S6psP8IUSzNtjwAfnOLzb9PZ0XtGSWwRMZHB5eeo1SqJLSJ6lVxVULcktojoNeBrRZPYImIiu1+jovMmiS0ieqXGFhHtYjw6WncQpSSxRcREB7YtGmBJbBHRK9M9IqJNDDg1tohoFTs1tohon0EfPJD7OKwr6WHgv2e4bQWwpw/hFJV4Zta0mBZyPC+2/YIyBUi6mk7MReyxva7M8+ZDXxNbEZJGnm3jun5LPDNrWkyJJ7JtUUS0ThJbRLROExPbproDmCTxzKxpMSWeBa5xfWwREWU1scYWEVFKEltEtE5jEpukdZLulrRd0oxvoelDPGsk/VTSnZLukHRu3TEBSBqSdIukHzYgludJ2iLpV5LukvS6muP5WPd3dbukyyUdXEMMl0jaLen2cZ8tl3StpHu6X5f1O66FphGJTdIQcBHwNuB44AxJx9cbFfuBT9g+HjgZ+JsGxARwLnBX3UF0fQ242vYrgD+mxrgkrQI+Quf1bCcAQ8DpNYTybWDyhNXzgOtsHwdc172OedSIxAacBGy3fa/tfcAVwPo6A7K9y/bN3fPf0/mfdlWdMUlaDbwDKPVqsopiOQJ4I/BNANv7bP9vrUF1lgg+V9Ji4BDggX4HYPtnwN5JH68HNnfPNwPv6mdMC1FTEtsqYMe4653UnETGk3QMcCJwQ82hXAh8CmjCCuVjgYeBb3WbxhdLWlpXMLbvB74E3AfsAh61/aO64plkpe1d3fMHgZV1BrMQNCWxNZakQ4HvAx+1/bsa43gnsNv2TXXFMMli4NXA122fCDxOjU2sbr/VejoJ90XAUkln1hXPdNyZX5U5VvOsKYntfmDNuOvV3c9qJek5dJLaZbavrDmcU4DTJP0Xnab6WyRdWmM8O4Gdtg/UYrfQSXR1WQv81vbDtp8GrgReX2M84z0k6SiA7tfdNcfTek1JbDcCx0k6VtISOp2+W+sMSJLo9B/dZfsrdcYCYPvTtlfbPobOz+cntmurkdh+ENgh6eXdj04F7qwrHjpN0JMlHdL93Z1KcwZZtgIbuucbgB/UGMuC0Ij92Gzvl3QOcA2d0axLbN9Rc1inAO8Hfinp1u5nf2d7W30hNc6Hgcu6f4zuBT5QVyC2b5C0BbiZzoj2LdSwlEnS5cCbgRWSdgKfBS4A/lnS2XS27XpPv+NaaLKkKiJapylN0YiIyiSxRUTrJLFFROsksUVE6ySxRUTrJLFFROsksUVE6/wfchBC52bJccYAAAAASUVORK5CYII=\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we commit this without outputs? At least to get git to realize this is a rename and not a wholesale deletion and addition

@mpharrigan
Copy link
Collaborator

There's also the "odd qubit" example notebook still in the hfvqe module. What do you want to do with that?

@mpharrigan
Copy link
Collaborator

Discussed offline: the hfvqe readme should be ported to docs/hfvqe/index.md to serve as a "landing page"

@ncrubin
Copy link
Contributor Author

ncrubin commented Oct 23, 2020

@mpharrigan I see master already had the odd qubit tutorial. I was going to leave it in hfvqe since it doesn't add much to the example. I will open another PR to remove.

@ncrubin
Copy link
Contributor Author

ncrubin commented Oct 26, 2020

@mpharrigan let me know if I need to make any other structural changes.

@mpharrigan mpharrigan merged commit f499702 into quantumlib:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

Assignees
No one assigned
Labels
hfvqe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncrubin @mpharrigan