Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially wrong crime name for rule 00025.json #12

Closed
cryptax opened this issue Jul 6, 2021 · 2 comments
Closed

Potentially wrong crime name for rule 00025.json #12

cryptax opened this issue Jul 6, 2021 · 2 comments

Comments

@cryptax
Copy link
Contributor

cryptax commented Jul 6, 2021

Rule 00025.json has crime name "Monitor the broadcast action events (BOOT_COMPLETED)", but the API actually checks:

 "api": [
        {
            "class": "Landroid/content/Intent;",
            "method": "getAction",
            "descriptor": "()Ljava/lang/String;"
        },
        {
            "class": "Ljava/lang/String;",
            "method": "equals",
            "descriptor": "(Ljava/lang/Object;)Z"
        }
    ],

There is no way to know this is monitoring BOOT_COMPLETED with this rule, nor even broadcast actions, so I think the crime name should be adjusted.

@krnick
Copy link
Contributor

krnick commented Jul 7, 2021

Hi @cryptax
Thank you for pointing out this problem :D
I will adjust it to "Monitor the general action to be performed" based on the getAction description.

Would that be more clear?

krnick added a commit that referenced this issue Jul 7, 2021
Update the crime description to get it more clear for issue #12
krnick added a commit that referenced this issue Jul 8, 2021
Update the crime description to get it more clear for issue #12
@krnick
Copy link
Contributor

krnick commented Aug 4, 2021

closed in #13 .

@krnick krnick closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants