add option of skipping test case when first failure occured (#9) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quark-zju
reviewed
Jan 11, 2019
src/ljudge.cc
Outdated
| @@ -1413,6 +1417,11 @@ static Options parse_cli_options(int argc, const char *argv[]) { | |||
| REQUIRE_NARGV(1); | |||
| options.nthread = NEXT_NUMBER_ARG; | |||
| #endif | |||
| } else if (option == "skip-on-first-failure") { | |||
| if (options.nthread != 1) { | |||
There was a problem hiding this comment.
Perhaps nthread can be automatically set to 1 in this case so --skip-on-first-failure works without specifying threads explicitly.
reAsOn2010
force-pushed
the
skip-when-first-failure
branch
2 times, most recently
from
43ebd1c
to
dccd737
Compare
|
I saw the code already merged into master, so close. |
quark-zju
reviewed
Jan 11, 2019
| j::object testcase_result = run_testcase(opts.etc_dir, opts.cache_dir, opts.user_code_path, opts.checker_code_path, opts.envs, opts.cases[i], opts.skip_checker, opts.keep_stdout, opts.keep_stderr); | ||
| results[i] = j::value(testcase_result); | ||
| if (testcase_result["result"].to_str() != TestcaseResult::ACCEPTED) { | ||
| should_skip = true; |
There was a problem hiding this comment.
This seems a bit tricky for OpenMP. Although it compiles, I think it's better to make the openmp loop explicitly not mutate a variable outside the loop body.
There was a problem hiding this comment.
I see, seems better.
| @@ -108,6 +108,7 @@ namespace TestcaseResult { | |||
| const string FLOAT_POINT_EXCEPTION = "FLOAT_POINT_EXCEPTION"; | |||
| const string SEGMENTATION_FAULT = "SEGMENTATION_FAULT"; | |||
| const string WRONG_ANSWER = "WRONG_ANSWER"; | |||
| const string SKIPPED = "SKIPPED"; | |||
There was a problem hiding this comment.
Lines here are generated via cog. I have updated the cog comment.
quark-zju
pushed a commit
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used for ACM scoring rule...