Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embedding model build item #480

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Remove embedding model build item #480

merged 2 commits into from
Apr 22, 2024

Conversation

jmartisk
Copy link
Collaborator

This was kinda confusing, I've reworked the way the LangChain4jDevUIProcessor detects whether the embedding store page should be present

@jmartisk jmartisk requested a review from a team as a code owner April 22, 2024 10:15
geoand
geoand approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartisk jmartisk merged commit ffeb898 into quarkiverse:main Apr 22, 2024
12 checks passed
@jmartisk jmartisk deleted the remove-embedding-model-build-item branch April 22, 2024 10:50
@jmartisk jmartisk mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmartisk @geoand