Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifier to InProcessEmbeddingStore when needed #481

Closed
wants to merge 4 commits into from

Conversation

humcqc
Copy link
Contributor

@humcqc humcqc commented Apr 22, 2024

No description provided.

@humcqc humcqc requested a review from a team as a code owner April 22, 2024 10:36
@humcqc humcqc changed the title Add qualifier to InProcessEmbeddingStore when needed, FIX #475 Add qualifier to InProcessEmbeddingStore when needed Apr 22, 2024
@geoand geoand requested a review from jmartisk April 22, 2024 10:43
@jmartisk
Copy link
Collaborator

There's now a conflict due to #480 please resolve it (it should be pretty straightforward, I've removed the class EmbeddingModelBuildItem so now you simply don't have to produce it)

@jmartisk
Copy link
Collaborator

Hmm hold on, there's something wrong with the easy rag extension now. Let me check

@humcqc humcqc requested a review from jmartisk April 22, 2024 13:16
@humcqc
Copy link
Contributor Author

humcqc commented Apr 22, 2024

@jmartisk should be good.

@geoand
Copy link
Collaborator

geoand commented Apr 23, 2024

Please squash and rebase the changes onto main.

Thanks!

@humcqc
Copy link
Contributor Author

humcqc commented Apr 23, 2024

New PR done in #488. This one could be removed.

@humcqc humcqc closed this Apr 23, 2024
@humcqc humcqc deleted the main3 branch April 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants