Introduce global logging properties #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea! |
|
Right, I'll fix it soon |
This allows us to use quarkus.langchain4j.log-requests=true instead of specifying needing to specify the provider as well
|
I think it would also be nice to mention it on the Getting started page in the docs |
|
Having it in the docs definitely makes sense, but I am not sure which page you are referring to. |
|
the landing page https://docs.quarkiverse.io/quarkus-langchain4j/dev/index.html :) |
|
Would you like to push a commit with that change? |
|
Sure |
|
🙏🏼 |
cescoffier
approved these changes
May 3, 2024
|
Bedt feature ever ! (At least this morning thus far). |
jmartisk
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use quarkus.langchain4j.log-requests=true instead of specifying needing to specify the provider as well