-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rupert/additional function inputs #635
Rupert/additional function inputs #635
Conversation
Hi @ru4ert, thank you! Looks good! Can you add documentation to the new configuration? |
* Add custom/additional HTTP Headers or other args to every request | ||
*/ | ||
@ConfigItem(name = "additional-request-args") | ||
public Optional<String> additionalRequestArgs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IHO, I think that the property could be additional-request-headers
or something like it. WYT @hbelmiro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcruzdev I think your not limited to just headers. See my Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
🎊 PR Preview 94bb20b has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-635.surge.sh |
f5fcbaf
to
e5f868f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ru4ert thank you!
I think that you need to use the page docs/modules/ROOT/pages/includes/additional-request-args.adoc
into the index.adoc
.
LGTM! WYT @ricardozanini @hbelmiro? Good job @ru4ert! |
Fixes #643 |
@all-contributors add @ru4ert for code and tests. |
I've put up a pull request to add @ru4ert! 🎉 |
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
#625 (comment)