-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubernetes jobs to GH Actions workflow #1174
Conversation
35462e2
to
6d25399
Compare
6d25399
to
98c8270
Compare
Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version' |
98c8270
to
78da40e
Compare
Imho Kubernetes runs should be independent on the existing ones. It's more convenient to have the runs isolated - better for investigation and status overview. @michalvavrik @mjurc what's your take on this? |
Agreed, it should be standalone |
+1 |
935e106
to
a1d48b6
Compare
run tests |
If you want to compare results with Jenkins k8s runs, it will not work. I deleted all k8s clusters |
The |
@rsvoboda @mjurc in this PR CI workflow, K8 tests are part of the:
It took me while to figure it's there, but I suppose based on the failed test name and part of the workflow you know it's there.. Is this ok with you? Personally I'd prefer it separately. P.S.: I'll open PR for "daily", it doesn't make sense. |
On the other hand, I wonder if we shouldn't run it as part of the native tests instead of separately. Because we are loosing time in the native, let see:
I am thinking - if our FW is written correctly, it can reuse native executable most of the time (if not, fix FW) so that we don't need additional 40 m + 22 m. In my eyes, it should be something about 10 additional minutes as JVM requires additional Thoughts? |
@gtroitsk let's give one to two days to have a say, otherwise I suggest to run K8 native and baremetal native together to figure out if we can safe considerable time. |
@michalvavrik @gtroitsk I don't mind losing those minutes in daily build at all actually, since we're not in a hurry for daily build. So I still vote for keeping the Kuberenetes runs separate from the other natives. |
I agree with this solution for daily runs. In case of PRs CI separate native build extend running time almost twice |
I am concerned about CI workflow. The |
Alright, let's put it in together with CI native and see how stable it is. |
a1d48b6
to
c09ddab
Compare
Following jobs contain at least one flaky test: 'Linux - JVM build - Latest Version' |
I can see K8 tests running in native CI, new numbers are:
Which is big difference to previous times. IMO we should keep it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I added very unimportant comments. Please address them and merge this.
c09ddab
to
e605b7d
Compare
We need to revert this one as explained here #1191 (comment). I didn't mention this PR was from main repo and not fork. |
Summary
Closes #433
Adds jobs to run Kubernetes tests in JVM and Native modes for both PR and daily CI runs
Please check the relevant options
run tests
phrase in comment)Checklist: