Merge pull request #36351 from geoand/#36257

Properly handle invalid response body errors in Reactive REST Client
quarkusio · Oct 9, 2023 · 39113e3 · 39113e3
2 parents 6be99a4 + 7de4dcc
commit 39113e3
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/...e/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java b/...e/src/main/java/org/jboss/resteasy/reactive/client/handlers/ClientSendRequestHandler.java
@@ -322,22 +322,27 @@ public void handle(AsyncResult<Void> flushed) {
                                             new VertxClientInputStream(clientResponse, 100000, requestContext));
                             requestContext.resume();
                         } else {
-                            clientResponse.bodyHandler(new Handler<>() {
+                            clientResponse.body(new Handler<>() {
                                 @Override
-                                public void handle(Buffer buffer) {
-                                    if (loggingScope != LoggingScope.NONE) {
-                                        clientLogger.logResponse(clientResponse, false);
-                                    }
-                                    try {
-                                        if (buffer.length() > 0) {
-                                            requestContext.setResponseEntityStream(
-                                                    new ByteArrayInputStream(buffer.getBytes()));
-                                        } else {
-                                            requestContext.setResponseEntityStream(null);
+                                public void handle(AsyncResult<Buffer> ar) {
+                                    if (ar.succeeded()) {
+                                        if (loggingScope != LoggingScope.NONE) {
+                                            clientLogger.logResponse(clientResponse, false);
+                                        }
+                                        Buffer buffer = ar.result();
+                                        try {
+                                            if (buffer.length() > 0) {
+                                                requestContext.setResponseEntityStream(
+                                                        new ByteArrayInputStream(buffer.getBytes()));
+                                            } else {
+                                                requestContext.setResponseEntityStream(null);
+                                            }
+                                            requestContext.resume();
+                                        } catch (Throwable t) {
+                                            requestContext.resume(t);
                                         }
-                                        requestContext.resume();
-                                    } catch (Throwable t) {
-                                        requestContext.resume(t);
+                                    } else {
+                                        requestContext.resume(ar.cause());
                                     }
                                 }
                             });