Skip to content

Commit

Permalink
Merge pull request #16249 from famod/mvn-3.8.1
Browse files Browse the repository at this point in the history
Update to Maven 3.8.1 & use mvnw consequently in GH workflows
  • Loading branch information
gsmet committed Apr 15, 2021
2 parents daec6b7 + 2813cd5 commit 418f023
Show file tree
Hide file tree
Showing 21 changed files with 70 additions and 51 deletions.
41 changes: 27 additions & 14 deletions .github/workflows/ci-actions-incremental.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ jobs:
# note: '-Pincremental -Dgib.disable' shall only trigger the download of gitflow-incremental-builder, not activate it
# since -Dincremental deactivates dependencies in bom-descriptor-json (which we do need here), -P is used instead
run: |
mvn -T1C $COMMON_MAVEN_ARGS -DskipTests -DskipITs -Dinvoker.skip -Dno-format -Dtcks -Pincremental -Dgib.disable clean install
./mvnw -T1C $COMMON_MAVEN_ARGS -DskipTests -DskipITs -Dinvoker.skip -Dno-format -Dtcks -Pincremental -Dgib.disable clean install
- name: Verify extension dependencies
shell: bash
run: |
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
needs: build-jdk11
timeout-minutes: 240
env:
MAVEN_OPTS: -Xmx2048m -XX:MaxMetaspaceSize=1000m
MAVEN_OPTS: -Xmx2g -XX:MaxMetaspaceSize=1g
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
run: tar -xzf maven-repo.tgz -C ~
- name: Build
shell: bash
run: mvn $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -Dsurefire.timeout=600 -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools ${{ matrix.java.maven_args }} ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -Dsurefire.timeout=600 -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools ${{ matrix.java.maven_args }} ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand All @@ -253,7 +253,7 @@ jobs:
needs: build-jdk11
timeout-minutes: 180
env:
MAVEN_OPTS: -Xmx1408m -XX:MaxMetaspaceSize=1000m
MAVEN_OPTS: -Xmx1500m -XX:MaxMetaspaceSize=1g

steps:
- uses: actions/checkout@v2
Expand All @@ -277,7 +277,7 @@ jobs:
run: tar -xzf maven-repo.tgz -C ~
- name: Build
shell: bash
run: mvn $COMMON_MAVEN_ARGS -DskipDocs -Dformat.skip -Dsurefire.timeout=600 -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools install ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS -DskipDocs -Dformat.skip -Dsurefire.timeout=600 -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools install ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand All @@ -301,6 +301,8 @@ jobs:
linux-jvm-maven-tests:
name: Maven Tests - JDK ${{matrix.java.name}}
runs-on: ubuntu-latest
env:
MAVEN_OPTS: -Xmx2g -XX:MaxMetaspaceSize=1g
# Skip main in forks
if: "github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main')"
needs: build-jdk11
Expand Down Expand Up @@ -334,7 +336,7 @@ jobs:
with:
java-version: ${{ matrix.java.java-version }}
- name: Build
run: mvn $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven' ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven' ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand All @@ -356,6 +358,8 @@ jobs:
windows-jdk11-jvm-maven-tests:
name: Maven Tests - JDK 11 Windows
runs-on: windows-latest
env:
MAVEN_OPTS: -Xmx2g -XX:MaxMetaspaceSize=1g
# Skip main in forks
if: "github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main')"
needs: build-jdk11
Expand Down Expand Up @@ -384,7 +388,7 @@ jobs:
java-version: 11
- name: Build
shell: bash
run: mvn $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven' ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven' ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand All @@ -406,6 +410,9 @@ jobs:
gradle-tests-jdk11-jvm:
name: Gradle Tests - JDK 11 ${{matrix.os.family}}
runs-on: ${{matrix.os.name}}
env:
# leave more space for the actual gradle execution (which is just wrapped by maven)
MAVEN_OPTS: -Xmx1g
# Skip main in forks
if: "github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main')"
needs: build-jdk11
Expand Down Expand Up @@ -461,7 +468,7 @@ jobs:
working-directory: integration-tests/gradle
- name: Build
shell: bash
run: mvn $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl integration-tests/gradle ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl integration-tests/gradle ${{ needs.build-jdk11.outputs.gib_args }}
- name: Upload Surefire reports (if build failed)
uses: actions/upload-artifact@v2
if: failure()
Expand Down Expand Up @@ -506,7 +513,7 @@ jobs:
with:
java-version: ${{ matrix.java.java-version }}
- name: Build
run: mvn $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools' ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools' ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -556,7 +563,7 @@ jobs:
java-version: 11
- name: Build
shell: bash
run: mvn $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools' ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools' ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -618,7 +625,7 @@ jobs:
run: mvn -B --settings ../tcks/.github/mvn-settings.xml install
working-directory: ./resteasy-reactive-testsuite
- name: Verify with Maven
run: mvn $COMMON_MAVEN_ARGS -Dtcks -pl tcks -amd install ${{ needs.build-jdk11.outputs.gib_args }}
run: ./mvnw $COMMON_MAVEN_ARGS -Dtcks -pl tcks -amd install ${{ needs.build-jdk11.outputs.gib_args }}
working-directory: ./tcks
- name: Prepare failure archive (if maven failed)
if: failure()
Expand Down Expand Up @@ -657,6 +664,9 @@ jobs:
name: Native Tests - ${{matrix.category}}
needs: [build-jdk11, native-tests-read-json-matrix]
runs-on: ubuntu-latest
env:
# leave more space for the actual native compilation and execution
MAVEN_OPTS: -Xmx1g
# Skip main in forks
if: "github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main')"
# Ignore the following YAML Schema error
Expand Down Expand Up @@ -699,12 +709,12 @@ jobs:
run: |
for i in $TEST_MODULES
do modules+="integration-tests/$i,"; done
mvn $COMMON_MAVEN_ARGS -pl "${modules}" $NATIVE_TEST_MAVEN_OPTS ${{ needs.build-jdk11.outputs.gib_args }}
./mvnw $COMMON_MAVEN_ARGS -pl "${modules}" $NATIVE_TEST_MAVEN_OPTS ${{ needs.build-jdk11.outputs.gib_args }}
# add the 'simple with spaces' project to the run of 'Misc1' by executing it explicitly
# done because there is no good way to pass strings with empty values to the previous command
# so this hack is as good as any
if [ "$CATEGORY" == "Misc1" ]; then
mvn $COMMON_MAVEN_ARGS -Dnative -Dquarkus.native.container-build=true -pl 'integration-tests/simple with space/' verify ${{ needs.build-jdk11.outputs.gib_args }}
./mvnw $COMMON_MAVEN_ARGS -Dnative -Dquarkus.native.container-build=true -pl 'integration-tests/simple with space/' verify ${{ needs.build-jdk11.outputs.gib_args }}
fi
- name: Prepare failure archive (if maven failed)
if: failure()
Expand All @@ -727,6 +737,9 @@ jobs:
name: Native Tests - Windows - ${{matrix.category}}
needs: [build-jdk11, native-tests-read-json-matrix]
runs-on: windows-latest
env:
# leave more space for the actual native compilation and execution
MAVEN_OPTS: -Xmx1g
# Skip main in forks
if: "github.repository == 'quarkusio/quarkus' || !endsWith(github.ref, '/main')"
# Ignore the following YAML Schema error
Expand Down Expand Up @@ -789,7 +802,7 @@ jobs:
run: |
for i in $TEST_MODULES
do modules+="integration-tests/$i,"; done
mvn $COMMON_MAVEN_ARGS -pl "${modules}" $WINDOWS_NATIVE_TEST_MAVEN_OPTS ${{ needs.build-jdk11.outputs.gib_args }}
./mvnw $COMMON_MAVEN_ARGS -pl "${modules}" $WINDOWS_NATIVE_TEST_MAVEN_OPTS ${{ needs.build-jdk11.outputs.gib_args }}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ci-actions.yml.disabled
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
key: q2maven-${{ steps.get-date.outputs.date }}
- name: Build
run: |
mvn -T1C -e -B -DskipTests -DskipITs -Dinvoker.skip -Dno-format -Dtcks --settings .github/mvn-settings.xml clean install
./mvnw -T1C -e -B -DskipTests -DskipITs -Dinvoker.skip -Dno-format -Dtcks --settings .github/mvn-settings.xml clean install
- name: Verify extension dependencies
shell: bash
run: |
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
shell: bash
run: tar -xzf maven-repo.tgz -C ~
- name: Build with Maven
run: eval mvn $JVM_TEST_MAVEN_OPTS install -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools ${{ matrix.java.maven_args}}
run: eval ./mvnw $JVM_TEST_MAVEN_OPTS install -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools ${{ matrix.java.maven_args}}
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
run: tar -xzf maven-repo.tgz -C ~
- name: Build with Maven
shell: bash
run: mvn -B --settings .github/mvn-settings.xml -DskipDocs -Dformat.skip -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools install
run: ./mvnw -B --settings .github/mvn-settings.xml -DskipDocs -Dformat.skip -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devtools install
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -257,7 +257,7 @@ jobs:
with:
java-version: ${{ matrix.java.java-version }}
- name: Run Maven integration tests
run: eval mvn $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven'
run: eval ./mvnw $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven'
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -295,7 +295,7 @@ jobs:
java-version: 11
- name: Run Maven integration tests
shell: bash
run: mvn $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven'
run: ./mvnw $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/maven'
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -411,7 +411,7 @@ jobs:
with:
java-version: ${{ matrix.java.java-version }}
- name: Run Devtools integration tests
run: eval mvn $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools'
run: eval ./mvnw $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools'
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -449,7 +449,7 @@ jobs:
java-version: 11
- name: Run Devtools integration tests
shell: bash
run: mvn $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools'
run: ./mvnw $JVM_TEST_MAVEN_OPTS install -pl 'integration-tests/devtools'
- name: Prepare failure archive (if maven failed)
if: failure()
shell: bash
Expand Down Expand Up @@ -498,7 +498,7 @@ jobs:
run: mvn -B --settings ../tcks/.github/mvn-settings.xml install
working-directory: ./resteasy-reactive-testsuite
- name: Verify with Maven
run: mvn -B --settings .github/mvn-settings.xml -f tcks/pom.xml install
run: ../mvnw -B --settings .github/mvn-settings.xml -f tcks/pom.xml install
working-directory: ./tcks
- name: Prepare failure archive (if maven failed)
if: failure()
Expand Down Expand Up @@ -568,12 +568,12 @@ jobs:
for i in $TEST_MODULES
do modules+=("integration-tests/$i"); done
IFS=,
eval mvn -pl "${modules[*]}" $NATIVE_TEST_MAVEN_OPTS
eval ./mvnw -pl "${modules[*]}" $NATIVE_TEST_MAVEN_OPTS
# add the 'simple with spaces' project to the run of 'Misc1' by executing it explicitly
# done because there is no good way to pass strings with empty values to the previous command
# so this hack is as good as any
if [ "$CATEGORY" == "Misc1" ]; then
mvn -Dnative -Dquarkus.native.container-build=true -B --settings .github/mvn-settings.xml -f 'integration-tests/simple with space/' verify
./mvnw -Dnative -Dquarkus.native.container-build=true -B --settings .github/mvn-settings.xml -f 'integration-tests/simple with space/' verify
fi
- name: Prepare failure archive (if maven failed)
if: failure()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-fork-mvn-cache.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
key: q2maven-${{ steps.get-date.outputs.date }}
- name: Build
run: |
mvn -T1C -e -B --settings .github/mvn-settings.xml -Dquickly-ci -Dtcks clean install
./mvnw -T1C -e -B --settings .github/mvn-settings.xml -Dquickly-ci -Dtcks clean install
- name: Delete Local Artifacts From Cache
shell: bash
run: rm -r ~/.m2/repository/io/quarkus
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:

- if: matrix.language == 'java'
name: Build Java
run: mvn -B --settings .github/mvn-settings.xml -Dquickly-ci install
run: ./mvnw -B --settings .github/mvn-settings.xml -Dquickly-ci install

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
2 changes: 1 addition & 1 deletion .github/workflows/deploy-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
SERVER_USERNAME: ${{ secrets.SERVER_USERNAME }}
SERVER_PASSWORD: ${{ secrets.SERVER_PASSWORD }}
run: |
mvn -e -B --settings .github/mvn-settings.xml \
./mvnw -e -B --settings .github/mvn-settings.xml \
-DskipITs -Dno-format -Dinvoker.skip=true \
-DretryFailedDeploymentCount=10 \
clean deploy
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/doc-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
key: q2maven-doc-${{ steps.get-date.outputs.date }}
- name: Build
run: |
mvn -Dquickly-ci -B --settings .github/mvn-settings.xml install
./mvnw -Dquickly-ci -B --settings .github/mvn-settings.xml install
- name: Build Docs
run: |
mvn -e -B --settings .github/mvn-settings.xml clean org.asciidoctor:asciidoctor-maven-plugin:process-asciidoc -pl docs -Ddocumentation-pdf
./mvnw -e -B --settings .github/mvn-settings.xml clean org.asciidoctor:asciidoctor-maven-plugin:process-asciidoc -pl docs -Ddocumentation-pdf
2 changes: 1 addition & 1 deletion .github/workflows/jdk-early-access-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
# -fae to try to gather as many failures as possible
# (but not maven.test.failure.ignore because test report generation is buggy)
run: |
mvn $JVM_TEST_MAVEN_OPTS -Dtcks install -fae
./mvnw $JVM_TEST_MAVEN_OPTS -Dtcks install -fae
# Test reports disabled due to: https://github.com/ScaCap/action-surefire-report/issues/39
#- name: Publish Test Report
# if: always()
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/native-cron-build.yml.disabled
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ jobs:
${{ runner.os }}-native-cron-

- name: Build Quarkus
run: mvn -B install -DskipTests -DskipITs -Dformat.skip
run: ./mvnw -B install -DskipTests -DskipITs -Dformat.skip

- name: Run integration tests in native
run: mvn -B --settings .github/mvn-settings.xml verify -f integration-tests/pom.xml --fail-at-end -Dno-format -Dtest-containers -Dstart-containers -Dnative -Dquarkus.native.container-build=true -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-native-image:20.2.0-java${{ matrix.java }} -pl '!io.quarkus:quarkus-integration-test-google-cloud-functions-http,!io.quarkus:quarkus-integration-test-google-cloud-functions,!io.quarkus:quarkus-integration-test-funqy-google-cloud-functions'
run: ./mvnw -B --settings .github/mvn-settings.xml verify -f integration-tests/pom.xml --fail-at-end -Dno-format -Dtest-containers -Dstart-containers -Dnative -Dquarkus.native.container-build=true -Dquarkus.native.builder-image=quay.io/quarkus/ubi-quarkus-native-image:20.2.0-java${{ matrix.java }} -pl '!io.quarkus:quarkus-integration-test-google-cloud-functions-http,!io.quarkus:quarkus-integration-test-google-cloud-functions,!io.quarkus:quarkus-integration-test-funqy-google-cloud-functions'

- name: Report
if: always()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
run: mkdir -p $HOME/release/repository
- name: Build and Test
run: |
mvn --settings .github/mvn-settings.xml \
./mvnw --settings .github/mvn-settings.xml \
-B \
-DskipITs -Dinvoker.skip=true \
-Dmaven.repo.local=$HOME/release/repository \
Expand Down
2 changes: 1 addition & 1 deletion .mvn/wrapper/MavenWrapperDownloader.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
2 changes: 1 addition & 1 deletion .mvn/wrapper/maven-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.1/apache-maven-3.8.1-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar
4 changes: 2 additions & 2 deletions bom/application/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@
<asm.version>9.1</asm.version>
<commons-io.version>2.8.0</commons-io.version>
<jboss-metadata-web.version>11.0.0.Final</jboss-metadata-web.version>
<maven-core.version>3.6.3</maven-core.version>
<maven-resolver.version>1.4.1</maven-resolver.version>
<maven-core.version>3.8.1</maven-core.version>
<maven-resolver.version>1.6.2</maven-resolver.version>
<maven-toolchain.version>3.0-alpha-2</maven-toolchain.version>
<guava.version>30.1.1-jre</guava.version>
<plexus-utils.version>3.2.1</plexus-utils.version>
Expand Down
Loading

0 comments on commit 418f023

Please sign in to comment.