Using optimized Vertx HTTP header names

quarkusio · Dec 8, 2023 · f6e9240 · f6e9240
1 parent 87eb294
commit f6e9240
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/...ons/reactive-routes/runtime/src/main/java/io/quarkus/vertx/web/runtime/RouteHandlers.java b/...ons/reactive-routes/runtime/src/main/java/io/quarkus/vertx/web/runtime/RouteHandlers.java
@@ -1,5 +1,7 @@
 package io.quarkus.vertx.web.runtime;
 
+import static io.vertx.core.http.HttpHeaders.CONTENT_TYPE;
+
 import io.vertx.core.Handler;
 import io.vertx.core.http.HttpServerResponse;
 import io.vertx.ext.web.RoutingContext;
@@ -9,15 +11,14 @@ public final class RouteHandlers {
     private RouteHandlers() {
     }
 
-    static final String CONTENT_TYPE = "content-type";
-
     public static void setContentType(RoutingContext context, String defaultContentType) {
         HttpServerResponse response = context.response();
         context.addHeadersEndHandler(new Handler<Void>() {
             @Override
             public void handle(Void aVoid) {
+                var headers = response.headers();
                 //use a listener to set the content type if it has not been set
-                if (response.headers().get(CONTENT_TYPE) == null) {
+                if (!headers.contains(CONTENT_TYPE)) {
                     String acceptableContentType = context.getAcceptableContentType();
                     if (acceptableContentType != null) {
                         response.putHeader(CONTENT_TYPE, acceptableContentType);

diff --git a/...reactive-routes/runtime/src/main/java/io/quarkus/vertx/web/runtime/ValidationSupport.java b/...reactive-routes/runtime/src/main/java/io/quarkus/vertx/web/runtime/ValidationSupport.java
@@ -10,6 +10,7 @@
 import jakarta.validation.Validator;
 
 import io.quarkus.arc.ArcContainer;
+import io.vertx.core.http.HttpHeaders;
 import io.vertx.core.http.HttpServerResponse;
 import io.vertx.core.json.JsonArray;
 import io.vertx.core.json.JsonObject;
@@ -70,7 +71,7 @@ private static JsonObject generateJsonResponse(Set<ConstraintViolation<?>> viola
     public static void handleViolationException(ConstraintViolationException ex, RoutingContext rc, boolean forceJsonEncoding) {
         String accept = rc.request().getHeader(ACCEPT_HEADER);
         if (forceJsonEncoding || accept != null && accept.contains(APPLICATION_JSON)) {
-            rc.response().putHeader(RouteHandlers.CONTENT_TYPE, APPLICATION_JSON);
+            rc.response().putHeader(HttpHeaders.CONTENT_TYPE, APPLICATION_JSON);
             JsonObject json = generateJsonResponse(ex.getConstraintViolations(), false);
             rc.response().setStatusCode(json.getInteger(PROBLEM_STATUS));
             rc.response().end(json.encode());