Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL client authentication for consul-config extension #10117

Closed
crissi98 opened this issue Jun 19, 2020 · 4 comments
Closed

SSL client authentication for consul-config extension #10117

crissi98 opened this issue Jun 19, 2020 · 4 comments
Labels
kind/enhancement New feature or request
Milestone

Comments

@crissi98
Copy link

Description
There should be a way to provide a keystore with a client certificate for the consul-config extension to use for client authentification with the consul agent.

Implementation ideas
By now, there is a config property called quarkus.consul-config.agent.key-store. This property is used to provide a truststore. In my opinion, this property should be renamed to quarkus.consul-config.agent.trust-store and the property quarkus.consul-config.agent.key-store should be used to provide a keystore with the client certificate.
I already implemented these changes on my own fork which you can find here: https://github.com/crissi98/quarkus/tree/consul-key-store/extensions/consul-config

@crissi98 crissi98 added the kind/enhancement New feature or request label Jun 19, 2020
@geoand
Copy link
Contributor

geoand commented Jun 19, 2020

Makes sense,

would you like to provide a PR?
Also, have you tried your code in native mode?

@crissi98
Copy link
Author

I did not try it in native mode yet. I will verify that it is working in native mode and then i would like to provide a PR.

@crissi98
Copy link
Author

I tested it in native mode and it does also work

@crissi98 crissi98 changed the title SSL client authentification for consul-config extension SSL client authentication for consul-config extension Jun 22, 2020
@crissi98
Copy link
Author

Closing this since it is fixed by #10145

@gsmet gsmet added this to the 1.6.0 - master milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants