Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP Security - configuration needs to be modifiable at runtime #10259

Closed
hyperman1 opened this issue Jun 25, 2020 · 3 comments · Fixed by #10334
Closed

LDAP Security - configuration needs to be modifiable at runtime #10259

hyperman1 opened this issue Jun 25, 2020 · 3 comments · Fixed by #10334
Labels
kind/enhancement New feature or request
Milestone

Comments

@hyperman1
Copy link

Description
See https://quarkus.io/guides/security-ldap#configuration-reference

All properties are fixed at build time. But in a realistic enterprise, these will differ between dev preprod prod environments (otherwise your dev credentials would also work in prod). There will be individual server URLs with individual bind credentials, users and groups are probably stored in different placess o the base dn's and filters will differ, etc..

As a bonus, the bind credentials should not be required, ldap has the concept of an anonymous bind.
-> quarkus.security.ldap.dir-context.principal and quarkus.security.ldap.dir-context.password can be null

@hartimcwildfly
Copy link

hartimcwildfly commented Jun 25, 2020

This is a presentation error. The config can be changed at runtime. Even if the documentation says it's fixed at build time. I don't know why this is the case.
ElytronSecurityLdapProcessor#configureLdapRealmAuthConfig has the annotation: Record(ExecutionTime.RUNTIME_INIT)

On your second point I fully aggree.

@gsmet gsmet changed the title LDAP Security - configuration needs to be modifyable at runtime LDAP Security - configuration needs to be modifiable at runtime Jun 29, 2020
@gsmet
Copy link
Member

gsmet commented Jun 29, 2020

Could you try #10334 ?

Tips from https://github.com/quarkusio/quarkus/blob/master/CONTRIBUTING.md#checking-an-issue-is-fixed-in-master might be useful in order to test the PR.

@hyperman1
Copy link
Author

I can't try much. Our corporate proxy does not allow acces to your snapshots or git. I'll see if I can find a workaround

@gsmet gsmet added this to the 1.6.0.Final milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants