Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give warning when REST Data HAL endpoint cannot be exposed properly #11246

Closed
gytis opened this issue Aug 6, 2020 · 2 comments
Closed

Give warning when REST Data HAL endpoint cannot be exposed properly #11246

gytis opened this issue Aug 6, 2020 · 2 comments
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@gytis
Copy link

gytis commented Aug 6, 2020

REST Data extension supports generating endpoints that return application/hal+json content. However, it requires a custom serialiser implementation which depends on quarkus-resteasy-jackson or quarkus-resteasy-jsonb being defined in an application's pom. This requirement is listed in an extension guide, but Quarkus won't give any warning when an actual application is build without such dependencies. Application would silently expose a hal endpoint, but the returned object would not be serialised in a correct format.
It would be helpful and less confusing for a user if an extension would print a warning and not expose a HAL endpoint if not all prerequisites are met.

@gytis gytis added the kind/enhancement New feature or request label Aug 6, 2020
@gytis
Copy link
Author

gytis commented Aug 6, 2020

I'll fix this problem, so please assign it to me.

gytis pushed a commit to gytis/quarkus that referenced this issue Aug 6, 2020
gytis pushed a commit to gytis/quarkus that referenced this issue Aug 7, 2020
gytis pushed a commit to gytis/quarkus that referenced this issue Aug 20, 2020
gytis pushed a commit to gytis/quarkus that referenced this issue Oct 26, 2020
gytis pushed a commit to gytis/quarkus that referenced this issue Nov 4, 2020
gytis pushed a commit to gytis/quarkus that referenced this issue Dec 9, 2020
gytis pushed a commit to gytis/quarkus that referenced this issue Jan 20, 2021
gytis pushed a commit to gytis/quarkus that referenced this issue Mar 15, 2021
geoand added a commit that referenced this issue Mar 15, 2021
…liser

Fail build with HAL resource without serializer #11246
@geoand
Copy link
Contributor

geoand commented Jul 27, 2021

This has already been fixed

@geoand geoand closed this as completed Jul 27, 2021
@geoand geoand added the triage/out-of-date This issue/PR is no longer valid or relevant label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

2 participants