Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESTEasy Reactive: change default name mapping strategy for @RestHeader #13665

Closed
FroMage opened this issue Dec 3, 2020 · 4 comments · Fixed by #16003 or #28851
Closed

RESTEasy Reactive: change default name mapping strategy for @RestHeader #13665

FroMage opened this issue Dec 3, 2020 · 4 comments · Fixed by #16003 or #28851
Assignees
@geoand
Labels
area/resteasy-reactive kind/enhancement New feature or request
Milestone
2.13.4.Final

Comments

@FroMage
Copy link
Member

FroMage commented Dec 3, 2020

ATM if you define your param as @RestHeader String contentType it will map to the contentType header, but it should map to Content-Type, so we have to adjust the name mapping rules to make it work for all HTTP headers by default.
@jjaferson jjaferson mentioned this issue Mar 24, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 30, 2021
@FroMage FroMage mentioned this issue Oct 25, 2022
Closed
@FroMage FroMage reopened this Oct 26, 2022
@FroMage
Copy link
Member Author

FroMage commented Oct 26, 2022

This turns out to generate the content-Type header for @RestHeader String contentType because it doesn't change the casing: it just hyphenates. Given that headers are case-insensitive, it's not critical, but we should still fix it. Also, this was added to the server, but not the client, making them incompatible when using @RestHeader with no argument.

@geoand geoand self-assigned this Oct 26, 2022
geoand added a commit to geoand/quarkus that referenced this issue Oct 26, 2022
@geoand
Fix deduced value for @RestHeader without a value
d468dd4 
We essentially make the first letter of every part
an uppercase letter for consistence

Part of quarkusio#13665
geoand added a commit to geoand/quarkus that referenced this issue Oct 26, 2022
@geoand
Add test for client usage of @RestHeader on the Reactive REST Client
b1516b1 
Closes: quarkusio#13665
@geoand
Copy link
Contributor

geoand commented Oct 26, 2022 •
edited

Are you sure the client doesn't work properly?

Because I am seeing that it does send the proper header name (I also used Wireshark to verify it)

@geoand geoand mentioned this issue Oct 26, 2022
Merged
FroMage added a commit to FroMage/quarkus that referenced this issue Oct 26, 2022
@FroMage
RESTEasyReactive: support @Rest* annotations on bean params for the…
388815d 
… client

- Also use hyphenate on `@RestHeader` on client fields on bean params quarkusio#13665
- Added test for client bean param on fields, getters and regular
  parameters for good measure

Fixes quarkusio#28782
@FroMage FroMage mentioned this issue Oct 26, 2022
Merged
@FroMage
Copy link
Member Author

FroMage commented Oct 26, 2022

Without your fix, I saw the client generate content-Type and not Content-Type. But now I need to redo part of #28782 with your new method, so let's merge this.

@geoand
Copy link
Contributor

geoand commented Oct 26, 2022

👌🏼

geoand added a commit to geoand/quarkus that referenced this issue Oct 26, 2022
@geoand
Fix deduced value for @RestHeader without a value
684f553 
We essentially make the first letter of every part
an uppercase letter for consistence

Part of quarkusio#13665
geoand added a commit to geoand/quarkus that referenced this issue Oct 26, 2022
@geoand
Add test for client usage of @RestHeader on the Reactive REST Client
d93345c 
Closes: quarkusio#13665
FroMage added a commit to FroMage/quarkus that referenced this issue Oct 26, 2022
@FroMage
RESTEasyReactive: support @Rest* annotations on bean params for the…
49d2ef1 
… client

- Also use hyphenate on `@RestHeader` on client fields on bean params quarkusio#13665
- Added test for client bean param on fields, getters and regular
  parameters for good measure

Fixes quarkusio#28782
geoand added a commit that referenced this issue Oct 27, 2022
@geoand
Merge pull request #28851 from geoand/#13665-again
250b290 
Properly address the change default name mapping strategy for @RestHeader
FroMage added a commit to FroMage/quarkus that referenced this issue Oct 27, 2022
@FroMage
RESTEasyReactive: support @Rest* annotations on bean params for the…
368b496 
… client

- Also use hyphenate on `@RestHeader` on client fields on bean params quarkusio#13665
- Added test for client bean param on fields, getters and regular
  parameters for good measure

Fixes quarkusio#28782
tmihalac pushed a commit to tmihalac/quarkus that referenced this issue Oct 27, 2022
@geoand @tmihalac
Fix deduced value for @RestHeader without a value
0099896 
We essentially make the first letter of every part
an uppercase letter for consistence

Part of quarkusio#13665
tmihalac pushed a commit to tmihalac/quarkus that referenced this issue Oct 27, 2022
@geoand @tmihalac
Add test for client usage of @RestHeader on the Reactive REST Client
f9c5a27 
Closes: quarkusio#13665
@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 2.14.0.Final Oct 28, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 28, 2022
@geoand @gsmet
Fix deduced value for @RestHeader without a value
3fb7490 
We essentially make the first letter of every part
an uppercase letter for consistence

Part of quarkusio#13665

(cherry picked from commit 684f553)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 28, 2022
@geoand @gsmet
Add test for client usage of @RestHeader on the Reactive REST Client
4f7a426 
Closes: quarkusio#13665
(cherry picked from commit d93345c)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 28, 2022
@FroMage @gsmet
RESTEasyReactive: support @Rest* annotations on bean params for the…
fca471d 
… client

- Also use hyphenate on `@RestHeader` on client fields on bean params quarkusio#13665
- Added test for client bean param on fields, getters and regular
  parameters for good measure

Fixes quarkusio#28782

(cherry picked from commit 368b496)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 31, 2022
@FroMage @gsmet
RESTEasyReactive: support @Rest* annotations on bean params for the…
a0be44f 
… client

- Also use hyphenate on `@RestHeader` on client fields on bean params quarkusio#13665
- Added test for client bean param on fields, getters and regular
  parameters for good measure

Fixes quarkusio#28782

(cherry picked from commit 368b496)
@gsmet gsmet modified the milestones: 2.14.0.Final, 2.13.4.Final Oct 31, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 31, 2022
@geoand @gsmet
Fix deduced value for @RestHeader without a value
006535b 
We essentially make the first letter of every part
an uppercase letter for consistence

Part of quarkusio#13665

(cherry picked from commit 684f553)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 31, 2022
@geoand @gsmet
Add test for client usage of @RestHeader on the Reactive REST Client
949556a 
Closes: quarkusio#13665
(cherry picked from commit d93345c)
zakkak pushed a commit to zakkak/quarkus that referenced this issue Nov 15, 2022
@geoand @zakkak
Fix deduced value for @RestHeader without a value
221b6bc 
We essentially make the first letter of every part
an uppercase letter for consistence

Part of quarkusio#13665

(cherry picked from commit 684f553)
zakkak pushed a commit to zakkak/quarkus that referenced this issue Nov 15, 2022
@geoand @zakkak
Add test for client usage of @RestHeader on the Reactive REST Client
ce896bb 
Closes: quarkusio#13665
(cherry picked from commit d93345c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/resteasy-reactive kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.4.Final
3 participants
@FroMage @gsmet @geoand