Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev mode: support suppressing warnign about non existing source directory #14402

Closed
lburgazzoli opened this issue Jan 19, 2021 · 10 comments · Fixed by #14483
Closed

dev mode: support suppressing warnign about non existing source directory #14402

lburgazzoli opened this issue Jan 19, 2021 · 10 comments · Fixed by #14483
Labels
area/devmode kind/enhancement New feature or request
Milestone

Comments

@lburgazzoli
Copy link
Contributor

Description

Since version 1.3.0, camel-k has switched to Quarkus as default runtime. For troubleshooting purpose we have some pure java based examples which I'm now migrating to use quarkus:dev instead of the exec-maven-plugin and since in camel-k we basically do composition, we don't have any source in project and that leads to the following warning:

The project's sources directory does not exist /home/codespace/workspace/camel-k-runtime-example-kamelets/src/main/java

As it is perfectly fine for a camel-k project to be "source free", it would be nice to add an option to silence such warning

@lburgazzoli lburgazzoli added the kind/enhancement New feature or request label Jan 19, 2021
@ghost ghost added the area/devmode label Jan 19, 2021
@geoand
Copy link
Contributor

geoand commented Jan 20, 2021

What sort of option are you thinking of @lburgazzoli ?

@aloubyansky
Copy link
Member

Simply removing the warning, afaiu.

@geoand
Copy link
Contributor

geoand commented Jan 20, 2021

But isn't that warning useful for some users?

@aloubyansky
Copy link
Member

@lburgazzoli you do provide the resources dir with the application.properties, don't you? So in that case this is the only file that will be hot-reloadable. We probably need to adjust the check to include the resources dir in it.

@lburgazzoli
Copy link
Contributor Author

@geoand a property like the <noDeps>true</noDeps>, maybe <noSources>true</noSources> / <noResources>true</noResources>
@aloubyansky we can have an application.properties but it is not strictly mandatory as camel-k dev supports adds all the files that are relevant for camel-k among the hot-reloadables

@geoand
Copy link
Contributor

geoand commented Jan 21, 2021

Sounds good to me, but @aloubyansky is the SME here, so let's see what he says

@gsmet
Copy link
Member

gsmet commented Jan 21, 2021

Does this warning really have value? I would be in favor of just dropping it if it's in the way of some use cases.

@aloubyansky
Copy link
Member

I tend to agree with @gsmet. If somebody complains we can reconsider.

@geoand
Copy link
Contributor

geoand commented Jan 21, 2021

OK, fine with me

@lburgazzoli
Copy link
Contributor Author

@gsapountzis @geoand @aloubyansky thx

@ghost ghost added this to the 1.12 - master milestone Jan 22, 2021
@gsmet gsmet modified the milestones: 1.12 - master, 1.11.1.Final Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devmode kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants