Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing info in guide discussing Reactive Messaging and HTTP #14551

Closed
gunnarmorling opened this issue Jan 24, 2021 · 6 comments · Fixed by #19675
Closed

Confusing info in guide discussing Reactive Messaging and HTTP #14551

gunnarmorling opened this issue Jan 24, 2021 · 6 comments · Fixed by #19675
Assignees
@michalszynkiewicz
Labels
area/reactive-messaging area/smallrye kind/bug Something isn't working
Milestone
2.2.1.Final

Comments

@gunnarmorling
Copy link
Contributor

In https://quarkus.io/guides/reactive-messaging-http, a few things are confusing:

  • The title mentions WebSockets, whereas this seems not to be the case in the actual contents
  • The "trying it out" part speaks of AMQP, which didn't play a role before
@gunnarmorling gunnarmorling added the kind/bug Something isn't working label Jan 24, 2021
@ghost
Copy link

ghost commented Jan 24, 2021

/cc @cescoffier, @kenfinnigan, @phillip-kruger

@gunnarmorling gunnarmorling changed the title Confusing info in guide discussing reactive messaging and httP Confusing info in guide discussing Reactive Messaging and HTTP Jan 24, 2021
@michalszynkiewicz
Copy link
Member

And I see the configuration properties are not listed among all configuration options :(

michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Jan 25, 2021
@michalszynkiewicz
Reactive Messaging HTTP quickstart fixes, quarkusio#14551
92aa741
@michalszynkiewicz michalszynkiewicz mentioned this issue Jan 25, 2021
Merged
michalszynkiewicz added a commit to michalszynkiewicz/quarkus that referenced this issue Jan 25, 2021
@michalszynkiewicz
Reactive Messaging HTTP quickstart fixes, quarkusio#14551
630a3fd
@michalszynkiewicz
Copy link
Member

I created a PR that removes AMQP and adds some info on the WebSocket connector.
I also added a list of available properties for both connectors.

I'll leave this issue open to create a separate quickstart for websockets and document it in the guide

gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 26, 2021
@michalszynkiewicz @gsmet
Reactive Messaging HTTP quickstart fixes, quarkusio#14551
9cf8873 
(cherry picked from commit 630a3fd)
@cescoffier
Copy link
Member

@michalszynkiewicz any progress around the WebSocket QS?

@cescoffier
Copy link
Member

@michalszynkiewicz did we make any progress on this one?

@michalszynkiewicz
Copy link
Member

nope :(

@michalszynkiewicz michalszynkiewicz mentioned this issue Aug 26, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 27, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.1.Final Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalszynkiewicz michalszynkiewicz

Labels
area/reactive-messaging area/smallrye kind/bug Something isn't working
Projects
None yet
Milestone
2.2.1.Final
Development

Successfully merging a pull request may close this issue.

Reactive Messaging WebSocket Guide michalszynkiewicz/quarkus
4 participants
@gunnarmorling @cescoffier @gsmet @michalszynkiewicz