-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maven wrapper to the generated projects #1498
Labels
kind/enhancement
New feature or request
Milestone
Comments
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Mar 15, 2019
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Mar 15, 2019
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Mar 15, 2019
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Mar 15, 2019
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Mar 15, 2019
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Mar 15, 2019
Err... is it me or it doesn't work?
|
@fbricon by any chance, was it installed in the |
yup. Looks like someone blindly merged a PR without testing it first ;-) |
Yes and no :).
The issue is that the project creation has a different behavior depending
on if you are in an empty directory or not. If you are in an empty
directory, it will work as expected and that's what was tested. If you are
not in an empty directory, the project is created in a new directory and
the wrapper should also be installed in it.
I'm not a big fan of this behavior but @cescoffier disagrees with me :).
I will create another issue for this.
Thanks for reporting.
…On Sat, Mar 23, 2019 at 10:11 PM Fred Bricon ***@***.***> wrote:
yup. Looks like someone blindly merged a PR without testing it first ;-)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1498 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOHBeceUV0Pm-iUbjLkn9mrfAOxRMclks5vZpicgaJpZM4b03KN>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It makes sense to add the maven wrapper to the generated projects (and to the quickstarts) in order to avoid problems were users are using a wrong maven version.
@gsmet @cescoffier Do you agree? If so, I can implement this
The text was updated successfully, but these errors were encountered: