Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-kubernetes / quarkus-openshift extension pulls in additional 10+ MB of dependencies #15705

Closed
rsvoboda opened this issue Mar 14, 2021 · 13 comments · Fixed by #15716
Closed
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

quarkus-kubernetes / quarkus-openshift extension pulls in additional 10+ MB of dependencies
Affected version: Quarkus master

Quarkus 1.12.2.Final

du -cskh target/quarkus-app/
 11M	target/quarkus-app/
 11M	total
find target/quarkus-app/ | grep jar$ | wc -l
      70

Quarkus master

du -cskh target/quarkus-app/
 23M	target/quarkus-app/
 23M	total
find target/quarkus-app/ | grep jar$ | wc -l
     102

Reproducer:

mvn io.quarkus:quarkus-maven-plugin:1.12.2.Final:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=getting-started \
    -DclassName="org.acme.getting.started.GreetingResource" \
    -Dpath="/hello" -Dextensions="quarkus-kubernetes"
cd getting-started

mvn clean package -DskipTests
du -cskh target/quarkus-app/
find target/quarkus-app/ | grep jar$ | wc -l

mvn clean package -DskipTests -Dquarkus.platform.artifact-id=quarkus-bom \
  -Dquarkus.platform.version=999-SNAPSHOT -Dquarkus-plugin.version=999-SNAPSHOT
du -cskh target/quarkus-app/
find target/quarkus-app/ | grep jar$ | wc -l

A lot of new io.fabric8 deps appear in dependency tree and target/quarkus-app/ directory:

[INFO] |  |  \- io.fabric8:kubernetes-client:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-core:jar:5.1.1:compile
[INFO] |  |     |  \- io.fabric8:kubernetes-model-common:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-rbac:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-admissionregistration:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-apps:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-autoscaling:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-apiextensions:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-batch:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-certificates:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-coordination:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-discovery:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-events:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-extensions:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-networking:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-metrics:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-policy:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-scheduling:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-storageclass:jar:5.1.1:compile
[INFO] |  |     +- io.fabric8:kubernetes-model-node:jar:5.1.1:compile
[INFO] |  |     +- com.squareup.okhttp3:okhttp:jar:3.14.9:compile
[INFO] |  |     |  \- com.squareup.okio:okio:jar:1.17.2:compile
[INFO] |  |     +- com.squareup.okhttp3:logging-interceptor:jar:3.14.9:compile
[INFO] |  |     +- io.fabric8:zjsonpatch:jar:0.3.0:compile
[INFO] |  |     \- com.github.mifmif:generex:jar:1.0.2:compile
[INFO] |  |        \- dk.brics.automaton:automaton:jar:1.11-8:compile
@rsvoboda rsvoboda added the kind/bug Something isn't working label Mar 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 14, 2021

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Mar 14, 2021

Hm... I wonder if this is related to the change @aloubyansky made with regards to stricter dependency management

@aloubyansky
Copy link
Member

Could be

@rsvoboda
Copy link
Member Author

Happy Sunday guys :)!

@geoand
Copy link
Contributor

geoand commented Mar 14, 2021

I'll have to take a closer look tomorrow

@aloubyansky
Copy link
Member

I don't know what dependency requirements are in this case to suggest exclusions.

@geoand
Copy link
Contributor

geoand commented Mar 14, 2021

The quarkus-kubernetes and quarkus-openshift extensions should not result in any extra dependencies added to the runtime classpath.
They are purely a build time thing

@aloubyansky
Copy link
Member

Thanks @geoand Let me know if I can help with moving some dependencies around w/o breaking the validation.

@geoand
Copy link
Contributor

geoand commented Mar 14, 2021 via email

@rsvoboda
Copy link
Member Author

#15706 is how I noticed quarkus-kubernetes / quarkus-openshift problem. It seems there are more extensions which are causing increased memory requirements for native build with Quarkus master.

@geoand
Copy link
Contributor

geoand commented Mar 15, 2021

#15716 should take care of the issue

geoand added a commit that referenced this issue Mar 15, 2021
Ensure that quarkus-kubernetes does not pollute the runtime classpath
@quarkus-bot quarkus-bot bot added this to the 1.13 - main milestone Mar 15, 2021
@rsvoboda
Copy link
Member Author

Nice, numbers are back to 1.12.2.Final like numbers with the latest Quarkus master

du -cskh target/quarkus-app/
 11M	target/quarkus-app/
 11M	total
find target/quarkus-app/ | grep jar$ | wc -l
      73

@geoand
Copy link
Contributor

geoand commented Mar 16, 2021

Thanks for verifying @rsvoboda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants