Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Hibernate Reactive enableCollectionInDefaultFetchGroup must be set to true #15814

Closed
DavideD opened this issue Mar 17, 2021 · 2 comments · Fixed by #15818
Closed

For Hibernate Reactive enableCollectionInDefaultFetchGroup must be set to true #15814

DavideD opened this issue Mar 17, 2021 · 2 comments · Fixed by #15818
Assignees
@DavideD
Labels
area/hibernate-reactive area/persistence kind/bug Something isn't working
Milestone
1.13.0.Final

Comments

@DavideD
Copy link
Contributor

DavideD commented Mar 17, 2021

Currently, the Hibernate Reactive extension doesn't set the property and so enableCollectionInDefaultFetchGroup is set to false. This is the default value for ORM.

The result is that when we try to fetch lazy collection we have a LazyInitializationException errors.
See this issue on Hibernate Reactive for more details: hibernate/hibernate-reactive#663

Example of code causing the exception:

    @GET
    @Path("/findBooks/{authorId}")
    public Uni<Collection<Book>> reactiveFindBooks(@PathParam("authorId") Integer authorId) {
        return mutinySession.find(Author.class, authorId)
                .chain(author -> mutinySession.fetch(author.getBooks()));
    }
@DavideD DavideD added the kind/bug Something isn't working label Mar 17, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 17, 2021

/cc @Sanne, @gavinking

@DavideD
Copy link
Contributor Author

DavideD commented Mar 17, 2021

I already have a fix

DavideD added a commit to DavideD/quarkus that referenced this issue Mar 17, 2021
@DavideD
[quarkusio#15814] Set enableCollectionInDefaultFetchGroup to true for HR
76072c5 
The default for ORM is false, but when we create the SessionFactory
for Hibernate Reactive this value has to be true.

For more details, see:
hibernate/hibernate-reactive#663
DavideD added a commit to DavideD/quarkus that referenced this issue Mar 17, 2021
@DavideD
[quarkusio#15814] Test lazy fetch with Hibernate Reactive
c66ef37
DavideD added a commit to DavideD/quarkus that referenced this issue Mar 17, 2021
@DavideD
[quarkusio#15814] Test lazy fetch with Hibernate Reactive
63e1337
DavideD added a commit to DavideD/quarkus that referenced this issue Mar 17, 2021
@DavideD
[quarkusio#15814] Test lazy fetch with Hibernate Reactive
a62ab78
DavideD added a commit to DavideD/quarkus that referenced this issue Mar 17, 2021
@DavideD
[quarkusio#15814] Test lazy fetch with Hibernate Reactive
bfca16e
DavideD added a commit to DavideD/quarkus that referenced this issue Mar 17, 2021
@DavideD
[quarkusio#15814] Test lazy fetching with Hibernate Reactive
bf9e86d
@DavideD DavideD mentioned this issue Mar 17, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Mar 17, 2021
@gsmet gsmet modified the milestones: 1.14 - main, 1.13.0.Final Mar 23, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Mar 23, 2021
@DavideD @gsmet
[quarkusio#15814] Set enableCollectionInDefaultFetchGroup to true for HR
e83aa82 
The default for ORM is false, but when we create the SessionFactory
for Hibernate Reactive this value has to be true.

For more details, see:
hibernate/hibernate-reactive#663

(cherry picked from commit 76072c5)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Mar 23, 2021
@DavideD @gsmet
[quarkusio#15814] Test lazy fetching with Hibernate Reactive
579269d 
(cherry picked from commit bf9e86d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
area/hibernate-reactive area/persistence kind/bug Something isn't working
Projects
None yet
Milestone
1.13.0.Final
Development

Successfully merging a pull request may close this issue.

Lazy fetch associations with Hibernate Reactive DavideD/quarkus
2 participants
@DavideD @gsmet