Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyway initSql support #16226

Closed
bpasson opened this issue Apr 3, 2021 · 6 comments · Fixed by #16405
Closed

Flyway initSql support #16226

bpasson opened this issue Apr 3, 2021 · 6 comments · Fixed by #16405
Labels
area/flyway good first issue Good for newcomers kind/enhancement New feature or request
Milestone
1.13.2.Final

Comments

@bpasson
Copy link
Contributor

bpasson commented Apr 3, 2021

Description

Flyway has an initSql property to specify sql to run. This is useful e.g. for selecting a role in PostgreSQL to use for the migration. This is beneficial if you use vault generated users who also need to update schemas. Currently it cannot be specified in the extension configuration. I think it would be a good addition.
@bpasson bpasson added the kind/enhancement New feature or request label Apr 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 3, 2021

/cc @cristhiank, @gastaldi, @geoand, @gsmet

@gastaldi gastaldi added the good first issue Good for newcomers label Apr 3, 2021
@srisatya12
Copy link

Is the issue was assigned or can I work on this Sir?

@geoand
Copy link
Contributor

geoand commented Apr 6, 2021

You can work on it if you like

@srisatya12
Copy link

Sure Sir

gastaldi added a commit to gastaldi/quarkus that referenced this issue Apr 9, 2021
@gastaldi
Support Flyway's initSql property to specify SQL to run
502366b 
Fixes quarkusio#16226
gastaldi added a commit to gastaldi/quarkus that referenced this issue Apr 9, 2021
@gastaldi
Support Flyway's initSql property to specify SQL to run
a52fb43 
Fixes quarkusio#16226
@gastaldi gastaldi mentioned this issue Apr 9, 2021
Merged
@gastaldi
Copy link
Contributor

gastaldi commented Apr 9, 2021

@srisatya1197 hey, I just saw the conversation now. I needed this feature so I provided a PR, hope you don´t mind? 😃

gastaldi added a commit to gastaldi/quarkus that referenced this issue Apr 9, 2021
@gastaldi
Support Flyway's initSql property to specify SQL to run
da64e7f 
Fixes quarkusio#16226
gastaldi added a commit to gastaldi/quarkus that referenced this issue Apr 9, 2021
@gastaldi
Support Flyway's initSql property to specify SQL to run
5c36168 
Fixes quarkusio#16226
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 9, 2021
@srisatya12
Copy link

@gastaldi No worries Sir.

@gsmet gsmet modified the milestones: 2.0 - main, 1.13.2.Final Apr 10, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 10, 2021
@gastaldi @gsmet
Support Flyway's initSql property to specify SQL to run
0057e71 
Fixes quarkusio#16226

(cherry picked from commit 5c36168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/flyway good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Milestone
1.13.2.Final
Development

Successfully merging a pull request may close this issue.

Support Flyway's initSql property to specify SQL to run gastaldi/quarkus
5 participants
@gastaldi @gsmet @geoand @bpasson @srisatya12