Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC - consider exposing AbstractStub.withCompression(String) via GrpcClientConfiguration #17066

Closed
mkouba opened this issue May 7, 2021 · 1 comment · Fixed by #17167
Closed
Assignees
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented May 7, 2021

Right now, a user needs to modify each injected stub manually, e.g.

@Singleton
public class MyBean {

    private final MutinyHelloGrpc.MutinyHelloStub client;

    public MyBean(@GrpcClient("hello") MutinyHelloGrpc.MutinyHelloStub stub) {
       this.client = stub.withCompression("gzip");
    }

It might make sense to allow users to specify the default value in the application.properties file instead:

quarkus.grpc.clients.hello.compression=gzip
@mkouba mkouba added the kind/enhancement New feature or request label May 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 7, 2021

/cc @cescoffier, @michalszynkiewicz

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label May 7, 2021
@mkouba mkouba self-assigned this May 12, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue May 12, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue May 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant