Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gRPC micrometer metrics #17183

Closed
holledauer opened this issue May 12, 2021 · 5 comments · Fixed by #17447
Closed

Support gRPC micrometer metrics #17183

holledauer opened this issue May 12, 2021 · 5 comments · Fixed by #17447

Comments

@holledauer
Copy link

Description

Micrometer v1.7.0 can generate metrics for gRPC. See Link

It would be great if the gRPC extension could register the metrics automatically

@holledauer holledauer added the kind/enhancement New feature or request label May 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 12, 2021

@cescoffier
Copy link
Member

Definitely something we can add. We just need to check where things need to be wired.

@mkouba
Copy link
Contributor

mkouba commented May 24, 2021

It seems that there are client and server interceptors that accept an instance of MeterRegistry. So in theory, all we need to do is to instantiate the interceptors with the correct MeterRegistry and register them for each client/service. I can take a look later this week.

@cescoffier
Copy link
Member

Sync with @ebullient. The interceptor may need to be added to the micrometer extension (maybe, maybe not, only Erin knows :-))

@ebullient
Copy link
Contributor

I am not the only one, and I am happy for the help.

A few extensions use the core MetricsFactory build item to detect metrics (and micrometer) support: Mongo and Jaeger are probably better examples, Hibernate and agroal do something a little different. The kicker is to avoid anything that references (or imports) the micrometer api unless the extension is present (to ensure it remains an optional dependency). All of the examples above show that.

@mkouba mkouba self-assigned this May 24, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue May 25, 2021
Observability roadmap [Deprecated] automation moved this from Backlog to Done May 25, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants