Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSWatchUtil should assign a good name to the threads it starts #17254

Closed
Sanne opened this issue May 16, 2021 · 5 comments · Fixed by #18596
Closed

FSWatchUtil should assign a good name to the threads it starts #17254

Sanne opened this issue May 16, 2021 · 5 comments · Fixed by #18596
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@Sanne
Copy link
Member

Sanne commented May 16, 2021

Description

Apparently FSWatchUtil starts an Executor, but the threads this is spawning have name patterns like pool-406-thread-1.

It would be highly preferreable for all of our components to specify a good name for threads which are being started, to help with diagnostics.

@Sanne Sanne added kind/enhancement New feature or request good first issue Good for newcomers labels May 16, 2021
@SivaTharun
Copy link

@Sanne can i work on this issue, i see that the method observe with in the FSWatchUtil class, is instantiating a single thread executor, so one worker thread of thread pool size -1 , will be started.

what is the expectation regarding the naming conventions of the pool thread

@Sanne
Copy link
Member Author

Sanne commented May 17, 2021

thanks for offering help @SivaTharun !

Yes that's observe method is likely what needs to be patched. In terms of naming I would suggest a pattern like FSWatchUtil-thread-1

@Roshanchandipur
Copy link

I'm a beginner so can you suggest me how to get started.

@SivaTharun
Copy link

@Roshanchandipur i have already started to work on this issue and will raise a PR in a day or two.

@chetankokil
Copy link
Contributor

@Sanne if this issue is still open, can i give it a shot ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants