Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSWatchUtil should assign a good name to the threads it starts #18596

Merged
merged 1 commit into from
Jul 12, 2021
Merged

FSWatchUtil should assign a good name to the threads it starts #18596

merged 1 commit into from
Jul 12, 2021

Conversation

chetankokil
Copy link
Contributor

@chetankokil chetankokil commented Jul 11, 2021 •
edited by geoand

Fixes #17254

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 11, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)
  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not contain an issue number (use 'Fix Allow * expression for quarkus:add-extension #1234' in the description instead)

This message is automatically generated by a bot.

@chetankokil chetankokil changed the title [CK_bug#17254] : Added Thread Factory with default name to thread as as suggedted by … Fix FSWatchUtil should assign a good name to the threads it starts Jul 11, 2021
@chetankokil
Copy link
Contributor Author

@Sanne can you please check this PR #18596

@chetankokil chetankokil changed the title Fix FSWatchUtil should assign a good name to the threads it starts Fix #17254 FSWatchUtil should assign a good name to the threads it starts Jul 11, 2021
@geoand geoand changed the title Fix #17254 FSWatchUtil should assign a good name to the threads it starts FSWatchUtil should assign a good name to the threads it starts Jul 12, 2021
geoand
geoand approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
@gsmet gsmet merged commit f00296d into quarkusio:main Jul 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 12, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

FSWatchUtil should assign a good name to the threads it starts
3 participants
@chetankokil @geoand @gsmet