Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring Vert.x WebClient maxPoolSize in quarkus-oidc and quarkus-oidc-client #17666

Closed
sberyozkin opened this issue Jun 3, 2021 · 1 comment · Fixed by #17701
Closed

Support configuring Vert.x WebClient maxPoolSize in quarkus-oidc and quarkus-oidc-client #17666

sberyozkin opened this issue Jun 3, 2021 · 1 comment · Fixed by #17701
Labels
area/oidc kind/enhancement New feature or request
Milestone
2.1.0.CR1

Comments

@sberyozkin
Copy link
Member

sberyozkin commented Jun 3, 2021 •
edited

Description

Both quarkus-oidc and quarkus-oidc-client use Vert.x WebClient. quarkus-oidc may use it on every authentication request in the code flow to complete the flow and quarkus-oidc-client may use it frequently as well.

As shown at #17631 a client thread pool may get temp exhausted so it makes sense to make it configurable for both extensions

Implementation ideas

Add webClientMaxPoolSize to OidcCommonConfig - both extensions will pick it up
@sberyozkin sberyozkin added the kind/enhancement New feature or request label Jun 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 3, 2021

/cc @pedroigor

@quarkus-bot quarkus-bot bot added the area/oidc label Jun 3, 2021
@glefloch glefloch mentioned this issue Jun 4, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging a pull request may close this issue.

Support setting maxPoolSize for OIDC WebClients glefloch/quarkus
1 participant
@sberyozkin