Support setting maxPoolSize for OIDC WebClients #17701

glefloch · 2021-06-04T16:40:25Z

This allows a user setting the maxPoolSize of the Web client.

machi1990

LGTM

quarkus-bot · 2021-06-04T17:34:16Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `af7dfb1`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Security2	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode line 43 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode line 43 - More details - Source on GitHub

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-tenancy

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testResolveTenantIdentifierWebAppDynamic - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testSimpleOidcNoDiscovery - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testSimpleOidcJwtWithJwkRefresh - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testOpaqueTokenIntrospectionDisallowed - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testJwtTokenIntrospectionDisallowed - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testResolveTenantConfig - More details - Source on GitHub

...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java

sberyozkin · 2021-06-04T21:38:33Z

Hmm, strange test errors, the PR does not seem to be related

sberyozkin · 2021-06-04T21:48:21Z

May be it is a rebase problem ? The other PRs seem to be OK

quarkus-bot · 2021-06-05T08:26:24Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `0f85d03`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	Test failures	Logs	Raw logs
✖	Native Tests - Security2	`Build`	Test failures	Logs	Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode line 43 - More details - Source on GitHub

⚙️ JVM Tests - JDK 16 #

📦 extensions/oidc/deployment

✖ io.quarkus.oidc.test.CodeFlowDevModeTestCase.testAccessAndRefreshTokenInjectionDevMode line 43 - More details - Source on GitHub

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-tenancy

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testResolveTenantIdentifierWebAppDynamic - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testSimpleOidcNoDiscovery - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testSimpleOidcJwtWithJwkRefresh - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testOpaqueTokenIntrospectionDisallowed - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testJwtTokenIntrospectionDisallowed - More details - Source on GitHub

✖ io.quarkus.it.keycloak.BearerTokenAuthorizationInGraalITCase.testResolveTenantConfig - More details - Source on GitHub

glefloch · 2021-06-05T09:08:29Z

@sberyozkin I addressed your comments and rebase, but I still have those weird failures..

sberyozkin · 2021-06-05T10:14:22Z

@glefloch Good morning :-), this is strange as I can see other PRs being green. Do these tests pass locally in your branch ?

...nsions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java

...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java

sberyozkin · 2021-06-05T10:28:37Z

@glefloch Hi Guillaume, sorry it is proving a bit more difficult than it should've been :-). But indeed since we have the users sometimes creating OidcTenantConfig manually then all the fields should be initialized. I did not realize it yesterday

glefloch · 2021-06-05T15:14:04Z

@sberyozkin thanks for those tips, I updated the branch and tests pass locally.

sberyozkin

@glefloch thanks for your help with fixing this issue :-)

gsmet · 2021-06-07T09:17:21Z

...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java

+     * The maximum size of the connection pool used by the WebClient
+     */
+    @ConfigItem
+    public OptionalInt webClientMaxPoolSize = OptionalInt.empty();


Isn't connectionTimeout also related to the web client? If so, being consistent and dropping the webClient prefix would make sense.

Let's decide this before merging.

Yes this is related, it is used in the same method to set WebClientOption

@gsmet, @glefloch sure, maxPoolSize works as well, thanks

I updated the property name, and all related reference (getter/setter, ...)

quarkus-bot · 2021-06-08T09:56:10Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `31281db`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-06-08T10:37:50Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `31281db`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

webClient qualifier has been dropped to make it consistent with the other properties affecting WebClientOptions

glefloch requested a review from sberyozkin June 4, 2021 16:40

machi1990 approved these changes Jun 4, 2021

View reviewed changes

sberyozkin reviewed Jun 4, 2021

View reviewed changes

...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java Outdated Show resolved Hide resolved

glefloch force-pushed the fix/17666 branch from af7dfb1 to 0f85d03 Compare June 5, 2021 07:31

sberyozkin reviewed Jun 5, 2021

View reviewed changes

...nsions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonUtils.java Outdated Show resolved Hide resolved

sberyozkin reviewed Jun 5, 2021

View reviewed changes

...sions/oidc-common/runtime/src/main/java/io/quarkus/oidc/common/runtime/OidcCommonConfig.java Outdated Show resolved Hide resolved

glefloch force-pushed the fix/17666 branch from 0f85d03 to 817c86a Compare June 5, 2021 15:13

sberyozkin self-requested a review June 5, 2021 16:10

sberyozkin approved these changes Jun 5, 2021

View reviewed changes

sberyozkin added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 5, 2021

gsmet previously requested changes Jun 7, 2021

View reviewed changes

Support setting maxPoolSize for OIDC WebClients

31281db

glefloch force-pushed the fix/17666 branch from 817c86a to 31281db Compare June 8, 2021 09:44

sberyozkin merged commit 8f21a26 into quarkusio:main Jun 8, 2021

quarkus-bot bot added this to the 2.1 - main milestone Jun 8, 2021

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 8, 2021

glefloch deleted the fix/17666 branch August 19, 2021 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support setting maxPoolSize for OIDC WebClients #17701

Support setting maxPoolSize for OIDC WebClients #17701

glefloch commented Jun 4, 2021

machi1990 left a comment

quarkus-bot bot commented Jun 4, 2021 •

edited

Failing Jobs - Building `af7dfb1`

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/oidc/deployment

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-tenancy

sberyozkin commented Jun 4, 2021 •

edited

sberyozkin commented Jun 4, 2021

quarkus-bot bot commented Jun 5, 2021 •

edited

Failing Jobs - Building `0f85d03`

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/oidc/deployment

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-tenancy

glefloch commented Jun 5, 2021

sberyozkin commented Jun 5, 2021

sberyozkin commented Jun 5, 2021

glefloch commented Jun 5, 2021

sberyozkin left a comment

gsmet Jun 7, 2021

glefloch Jun 7, 2021

sberyozkin Jun 7, 2021

glefloch Jun 8, 2021

quarkus-bot bot commented Jun 8, 2021 •

edited

Failing Jobs - Building `31281db`

quarkus-bot bot commented Jun 8, 2021 •

edited

Failing Jobs - Building `31281db`

Support setting maxPoolSize for OIDC WebClients #17701

Support setting maxPoolSize for OIDC WebClients #17701

Conversation

glefloch commented Jun 4, 2021

machi1990 left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Jun 4, 2021 • edited

Failing Jobs - Building af7dfb1

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/oidc/deployment

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-tenancy

sberyozkin commented Jun 4, 2021 • edited

sberyozkin commented Jun 4, 2021

quarkus-bot bot commented Jun 5, 2021 • edited

Failing Jobs - Building 0f85d03

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc/deployment

⚙️ JVM Tests - JDK 16 #

📦 extensions/oidc/deployment

⚙️ Native Tests - Security2 #

📦 integration-tests/oidc-tenancy

glefloch commented Jun 5, 2021

sberyozkin commented Jun 5, 2021

sberyozkin commented Jun 5, 2021

glefloch commented Jun 5, 2021

sberyozkin left a comment

Choose a reason for hiding this comment

gsmet Jun 7, 2021

Choose a reason for hiding this comment

glefloch Jun 7, 2021

Choose a reason for hiding this comment

sberyozkin Jun 7, 2021

Choose a reason for hiding this comment

glefloch Jun 8, 2021

Choose a reason for hiding this comment

quarkus-bot bot commented Jun 8, 2021 • edited

Failing Jobs - Building 31281db

quarkus-bot bot commented Jun 8, 2021 • edited

Failing Jobs - Building 31281db

quarkus-bot bot commented Jun 4, 2021 •

edited

Failing Jobs - Building `af7dfb1`

sberyozkin commented Jun 4, 2021 •

edited

quarkus-bot bot commented Jun 5, 2021 •

edited

Failing Jobs - Building `0f85d03`

quarkus-bot bot commented Jun 8, 2021 •

edited

Failing Jobs - Building `31281db`

quarkus-bot bot commented Jun 8, 2021 •

edited

Failing Jobs - Building `31281db`