Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring query parameter from configuration using the Reactive REST Client #21443

Closed
cescoffier opened this issue Nov 14, 2021 · 7 comments · Fixed by #29277
Closed

Configuring query parameter from configuration using the Reactive REST Client #21443

cescoffier opened this issue Nov 14, 2021 · 7 comments · Fixed by #29277
Assignees
Labels
area/rest-client kind/epic Large issue with links to sub-issues
Milestone

Comments

@cescoffier
Copy link
Member

Description

This epic is about configuring per-class and per-method query parameters, with an annotation.
Values may come from the configuration.

@cescoffier cescoffier added area/rest-client kind/epic Large issue with links to sub-issues labels Nov 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 14, 2021

/cc @michalszynkiewicz

@michalszynkiewicz
Copy link
Member

We could introduce a @ClientQueryParam annotation for it.
Something like:

public @interface ClientQueryParam {
    String name();
    String value();
    boolean required() default false;
}

There's a chance we could reuse HeaderFiller for it.

@michalszynkiewicz michalszynkiewicz removed their assignment Aug 26, 2022
@michalszynkiewicz
Copy link
Member

CC @Sgitario

@geoand
Copy link
Contributor

geoand commented Nov 10, 2022

Not sure I get this. Can someone give an example of what we are looking for?

@cescoffier
Copy link
Member Author

Yhe idea as far as I understand is to annotate a REST client method with the ClientQueryParam to add the specified params as query parameters to the call. We have the same kind of feature for headers, but not for query parameters.

@geoand
Copy link
Contributor

geoand commented Nov 14, 2022

Okay cool, I'll add it.

geoand added a commit to geoand/quarkus that referenced this issue Nov 15, 2022
This is analogous to what MP REST Client provides
in @ClientHeaderParam

Resolves: quarkusio#21443
@geoand
Copy link
Contributor

geoand commented Nov 15, 2022

#29277 brings in this future

geoand added a commit to geoand/quarkus that referenced this issue Nov 15, 2022
This is analogous to what MP REST Client provides
in @ClientHeaderParam

Resolves: quarkusio#21443
geoand added a commit to geoand/quarkus that referenced this issue Nov 15, 2022
This is analogous to what MP REST Client provides
in @ClientHeaderParam

Resolves: quarkusio#21443
geoand added a commit to geoand/quarkus that referenced this issue Nov 15, 2022
This is analogous to what MP REST Client provides
in @ClientHeaderParam

Resolves: quarkusio#21443
geoand added a commit that referenced this issue Nov 16, 2022
Add @ClientQueryParam to Reactive REST Client
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest-client kind/epic Large issue with links to sub-issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants