Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about MetricCollectingClientInterceptor and MetricCollectingServerInterceptor when using grpc and micrometer #23011

Closed
rsvoboda opened this issue Jan 19, 2022 · 2 comments · Fixed by #23040
Labels
area/grpc gRPC area/metrics kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

Describe the bug

Warnings about MetricCollectingClientInterceptor and MetricCollectingServerInterceptor when using grpc and micrometer

Warnings:

  • At least one unused gRPC client interceptor found: io.micrometer.core.instrument.binder.grpc.MetricCollectingClientInterceptor. If there are meant to be used globally, annotate them with @GlobalInterceptor.
  • At least one unused gRPC interceptor found: io.micrometer.core.instrument.binder.grpc.MetricCollectingServerInterceptor. If there are meant to be used globally, annotate them with @GlobalInterceptor.

These warnings should be fixed or at least silenced using LogCleanupFilterBuildItem

[INFO] --- quarkus-maven-plugin:2.6.2.Final:build (default) @ code-with-quarkus ---
[INFO] [org.jboss.threads] JBoss Threads version 3.4.2.Final
[WARNING] [io.quarkus.grpc.deployment.GrpcClientProcessor] At least one unused gRPC client interceptor found: io.micrometer.core.instrument.binder.grpc.MetricCollectingClientInterceptor. If there are meant to be used globally, annotate them with @GlobalInterceptor.
[WARNING] [io.quarkus.grpc.deployment.GrpcServerProcessor] At least one unused gRPC interceptor found: io.micrometer.core.instrument.binder.grpc.MetricCollectingServerInterceptor. If there are meant to be used globally, annotate them with @GlobalInterceptor.
[INFO] [io.quarkus.deployment.QuarkusAugmentor] Quarkus augmentation completed in 921ms

Expected behavior

No warnings

Actual behavior

Warnings

[INFO] --- quarkus-maven-plugin:2.6.2.Final:build (default) @ code-with-quarkus ---
[INFO] [org.jboss.threads] JBoss Threads version 3.4.2.Final
[WARNING] [io.quarkus.grpc.deployment.GrpcClientProcessor] At least one unused gRPC client interceptor found: io.micrometer.core.instrument.binder.grpc.MetricCollectingClientInterceptor. If there are meant to be used globally, annotate them with @GlobalInterceptor.
[WARNING] [io.quarkus.grpc.deployment.GrpcServerProcessor] At least one unused gRPC interceptor found: io.micrometer.core.instrument.binder.grpc.MetricCollectingServerInterceptor. If there are meant to be used globally, annotate them with @GlobalInterceptor.
[INFO] [io.quarkus.deployment.QuarkusAugmentor] Quarkus augmentation completed in 921ms

How to Reproduce?

Output of uname -a or ver

macOS Monterey

Output of java -version

Java 17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.6.2.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda rsvoboda added the kind/bug Something isn't working label Jan 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 19, 2022

@cescoffier
Copy link
Member

Great catch!

Yes, we should exclude the metrics interceptors from the checked list.

cescoffier added a commit to cescoffier/quarkus that referenced this issue Jan 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 20, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 21, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 21, 2022
… non-global interceptors

(cherry picked from commit ef6d5f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC area/metrics kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants