Regression: Quarkus-cli create app doesn't auto-detect Host java version

[pjgg]

Describe the bug

When you create an app with Quarkus-cli 2.6.3 the tool detects the java version that is running in the developer environment and the resulted app has the same java version as the host.

This feature is broken in Quarkus 2.7.5.Final

Reproducer:

Quarkus 2.6.3

Install quarkus-cli 2.6.3: jbang app install --name qs2.6.3 io.quarkus:quarkus-cli:2.6.3.Final:runner
Create app: qs2.6.3 create app app

The pom has the same Java version as the host machine.

Quarkus 2.7.5

Install quarkus-cli 2.6.3: jbang app install --name qs2.7.5 io.quarkus:quarkus-cli:2.7.5.Final:runner
Create app: qs2.7.5 create app app
Pom Java version:<maven.compiler.release>11</maven.compiler.release>
Expected version: 17

Output of java -version

openjdk 17.0.1 2021-10-19 OpenJDK Runtime Environment Temurin-17.0.1+12 (build 17.0.1+12) OpenJDK 64-Bit Server VM Temurin-17.0.1+12 (build 17.0.1+12, mixed mode, sharing)

[quarkus-bot]

/cc @ebullient, @maxandersen, @quarkusio/devtools

[maxandersen]

okey thats weird but I can confirm it does not seem to work :/

@ebullient @ia3andy any ideas ?

[ebullient]

I think it is the match for the java version property...
we fall back to the default if it didn't match. So we're making a bad assumption about what a version string looks like (I haven't stared at the regex and I don't think I wrote it, but that's where the problem lies, I believe.. so if you have that version string handy, we can figure it out)

[gsmet]

Given we are targeting Java 11+ now, can't we use Runtime.version().feature() instead?
Maybe we need to check that GraalVM returns the underlying Java version and not the GraalVM version but I think it should probably work (and avoid things being brittle).

[gsmet]

Another possibility would be to use java.specification.version but if Runtime.version().feature() works OK, it's probably the way to go.

[ebullient]

perhaps? yes. This is what needs to be revised:

quarkus/independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java

Line 79 in 1c9dbbd

public static void setJavaVersion(Map<String, Object> values, String javaTarget) {

I won't be able to get there today.

[gsmet]

I will have a look. I need simple stuff today.

[maxandersen]

"java.version" is 17 on my local version so not sure why that code would fail to detect 17...

[gsmet]

As I said, I looked into and already have a patch ready. I’m running the Maven tests locally and will create a PR later today.

[gsmet]

And yes the main problem is not the detection but the CLI itself.

Anyway I’m out for a while, will open the PR when I’m back.

[gsmet]

@pjgg any chance you could check #24645 fixes the problem for you?