Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus.webauthn.relying-party.icon should be removed or deprecated #25676

Closed
ynojima opened this issue May 19, 2022 · 3 comments · Fixed by #25789
Closed

quarkus.webauthn.relying-party.icon should be removed or deprecated #25676

ynojima opened this issue May 19, 2022 · 3 comments · Fixed by #25789
Assignees
@FroMage
Labels
kind/enhancement New feature or request
Milestone
2.10.0.CR1

Comments

@ynojima
Copy link
Member

ynojima commented May 19, 2022

Description

From Quarkus 2.9.0, security-webauthn introduced quarkus.webauthn.relying-party.icon configuration property as a preview feature.
But W3C WebAuthn specification already deleted icon from PublicKeyCredentialEntity, and no browsers support the icon option, the configuration property should be removed or deprecated.

Implementation ideas

No response
@ynojima ynojima added the kind/enhancement New feature or request label May 19, 2022
@geoand
Copy link
Contributor

geoand commented May 19, 2022

cc @FroMage @sberyozkin

@FroMage
Copy link
Member

FroMage commented May 24, 2022

@pmlopes any opinion on this?

@pmlopes
Copy link
Contributor

pmlopes commented May 24, 2022

Yes, remove it. in vert.x auth we need to do a sync with the level-2 spec (current release) and remove it too.

gastaldi added a commit to gastaldi/quarkus that referenced this issue May 25, 2022
@gastaldi
Deprecate quarkus.webauthn.relying-party.icon
5ef5cbf 
Fixes quarkusio#25676
@gastaldi gastaldi mentioned this issue May 25, 2022
Merged
gastaldi added a commit to gastaldi/quarkus that referenced this issue May 25, 2022
@gastaldi
Remove quarkus.webauthn.relying-party.icon
f65d35a 
- Fixes quarkusio#25676
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FroMage FroMage

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
2.10.0.CR1
Development

Successfully merging a pull request may close this issue.

Remove quarkus.webauthn.relying-party.icon gastaldi/quarkus
4 participants
@FroMage @pmlopes @ynojima @geoand